ui: Fix live patch of routers - #6353
Merged
Merged
Conversation
|
Found UI changes, kicking a new UI QA build |
|
@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
weizhouapache
approved these changes
May 3, 2022
weizhouapache
left a comment
weizhouapache
left a comment
Member
There was a problem hiding this comment.
manually tested ok.
a question: if vpc does not have a tier, it seems nothing is changed in VR, is that expected behaviour ?
Contributor
Author
|
It patches the VR (VPC / otherwise) and then does whatever restartNetwork without cleanup does, so if the network doesn't have anything to program, I guess it does nothing @weizhouapache |
yadvr
approved these changes
May 3, 2022
nvazquez
approved these changes
May 3, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the invocation of wrong API in case a router of a VPC network is being live patched
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?