Skip to content

Bugfix: no support for XCPng 8.2.1 - #6362

Merged
nvazquez merged 2 commits into
apache:mainfrom
shapeblue:supportxcpng821
May 6, 2022
Merged

Bugfix: no support for XCPng 8.2.1#6362
nvazquez merged 2 commits into
apache:mainfrom
shapeblue:supportxcpng821

Conversation

@nvazquez

@nvazquez nvazquez commented May 6, 2022

Copy link
Copy Markdown
Contributor

Description

This PR adds initial support for XCPng 8.2.1 for a minimal working version based on the workaround found on #6349

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

@nvazquez nvazquez added this to the 4.17.0.0 milestone May 6, 2022
@nvazquez nvazquez mentioned this pull request May 6, 2022
Closed
@nvazquez

nvazquez commented May 6, 2022

Copy link
Copy Markdown
Contributor Author

@blueorangutan package

@blueorangutan

blueorangutan commented May 6, 2022

Copy link
Copy Markdown

@nvazquez a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@nvazquez nvazquez changed the title Initial support for XCPng 8.2.1 Bugfix: no support for XCPng 8.2.1 May 6, 2022
@nvazquez nvazquez linked an issue May 6, 2022 that may be closed by this pull request
No support for xcp-ng 8.2.1 - many hypervisor capabilities not available #6349
Closed
weizhouapache
weizhouapache reviewed May 6, 2022
View reviewed changes
Comment thread engine/schema/src/main/resources/META-INF/db/schema-41610to41700.sql Outdated

-- Copy XenServer 8.2.0 hypervisor guest OS mappings to XenServer 8.2.1
INSERT IGNORE INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, hypervisor_version, guest_os_name, guest_os_id, created, is_user_defined) SELECT UUID(),'Xenserver', '8.2.1', guest_os_name, guest_os_id, utc_timestamp(), 0 FROM `cloud`.`guest_os_hypervisor` WHERE hypervisor_type='Xenserver' AND hypervisor_version='8.2.0';
INSERT IGNORE INTO `cloud`.`guest_os_hypervisor` (hypervisor_type, guest_os_name, guest_os_id, hypervisor_version, uuid, created, removed, is_user_defined) VALUES ('Xenserver', 'Debian Bullseye 11', 337, '8.2.1', uuid(), now(), NULL, 0);

@weizhouapache weizhouapache May 6, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nvazquez
would be good to use the procedure cloud.ADD_GUEST_OS_AND_HYPERVISOR_MAPPING ?

@nvazquez nvazquez May 6, 2022

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, thanks

@weizhouapache

weizhouapache commented May 6, 2022

Copy link
Copy Markdown
Member

this seems not to be a bug :-D

@blueorangutan

blueorangutan commented May 6, 2022

Copy link
Copy Markdown

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 3359

@nvazquez

nvazquez commented May 6, 2022

Copy link
Copy Markdown
Contributor Author

Ping for review @AlexanderKgr @BenoitLair

@nvazquez

nvazquez commented May 6, 2022

Copy link
Copy Markdown
Contributor Author

@blueorangutan package

@blueorangutan

blueorangutan commented May 6, 2022

Copy link
Copy Markdown

@nvazquez a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan

blueorangutan commented May 6, 2022

Copy link
Copy Markdown

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 3360

weizhouapache
weizhouapache approved these changes May 6, 2022
View reviewed changes

@weizhouapache weizhouapache left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

@nvazquez

nvazquez commented May 6, 2022

Copy link
Copy Markdown
Contributor Author

Verified on vanilla env, no need to run tests

@nvazquez
nvazquez merged commit 362488e into apache:main May 6, 2022
@AlexanderKgr

AlexanderKgr commented May 17, 2022 •
edited
Loading

Copy link
Copy Markdown

sorry checked again and there is no problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yadvr yadvr yadvr approved these changes
@weizhouapache weizhouapache weizhouapache approved these changes
@Pearl1594 Pearl1594 Awaiting requested review from Pearl1594

Assignees

No one assigned

Labels

compatibilty component:XenServer type:bug

Projects

No open projects
Apache CloudStack 4.17.0
Status: Done

Milestone

4.17.0.0

Development

Successfully merging this pull request may close these issues.

No support for xcp-ng 8.2.1 - many hypervisor capabilities not available

5 participants

@nvazquez @blueorangutan @weizhouapache @AlexanderKgr @yadvr