Skip to content

Updated PowerFlex/ScaleIO storage plugin to support separate (storage) network for Hosts(KVM)/Storage connection. - #6367

Merged
yadvr merged 3 commits into
apache:4.17from
shapeblue:seperate-host-network-support-for-scaleio-storage
Jun 27, 2022
Merged

Updated PowerFlex/ScaleIO storage plugin to support separate (storage) network for Hosts(KVM)/Storage connection.#6367
yadvr merged 3 commits into
apache:4.17from
shapeblue:seperate-host-network-support-for-scaleio-storage

Conversation

@sureshanaparti

@sureshanaparti sureshanaparti commented May 9, 2022

Copy link
Copy Markdown
Contributor

Description

This PR enhances the existing PowerFlex/ScaleIO storage plugin to support separate (storage) network for Hosts(KVM)/Storage connection, mainly the SDC (ScaleIo Data Client) connection.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Manually tested VM/Volume operations on PowerFlex/ScaleIO storage.

@sureshanaparti

sureshanaparti commented May 9, 2022

Copy link
Copy Markdown
Contributor Author

@blueorangutan package

@blueorangutan

blueorangutan commented May 9, 2022

Copy link
Copy Markdown

@sureshanaparti a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@sureshanaparti
sureshanaparti force-pushed the seperate-host-network-support-for-scaleio-storage branch from 05006e4 to 6cdad85 Compare May 9, 2022 11:08
@apache apache deleted a comment from blueorangutan May 9, 2022
@sureshanaparti

sureshanaparti commented May 9, 2022

Copy link
Copy Markdown
Contributor Author

@blueorangutan package

@blueorangutan

blueorangutan commented May 9, 2022

Copy link
Copy Markdown

@sureshanaparti a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan

blueorangutan commented May 9, 2022

Copy link
Copy Markdown

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 3374

@sureshanaparti

sureshanaparti commented May 9, 2022

Copy link
Copy Markdown
Contributor Author

@blueorangutan test

@blueorangutan

blueorangutan commented May 9, 2022

Copy link
Copy Markdown

@sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan

blueorangutan commented May 9, 2022

Copy link
Copy Markdown

Trillian test result (tid-4152)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 37395 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6367-t4152-kvm-centos7.zip
Smoke tests completed. 96 look OK, 0 have errors
Only failed tests results shown below:

Test Result Time (s) Test File

@sureshanaparti

sureshanaparti commented May 10, 2022

Copy link
Copy Markdown
Contributor Author

@blueorangutan package

@blueorangutan

blueorangutan commented May 10, 2022

Copy link
Copy Markdown

@sureshanaparti a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan

blueorangutan commented May 10, 2022

Copy link
Copy Markdown

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 3379

@acs-robot

acs-robot commented May 11, 2022

Copy link
Copy Markdown

Found UI changes, kicking a new UI QA build
@blueorangutan ui

@blueorangutan

blueorangutan commented May 11, 2022

Copy link
Copy Markdown

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@sureshanaparti

sureshanaparti commented May 11, 2022

Copy link
Copy Markdown
Contributor Author

Hi @rohityadavcloud No UI changes in this PR, but bot detected UI changes. Can you check/fix it. Thanks.

@blueorangutan

blueorangutan commented May 11, 2022

Copy link
Copy Markdown

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6367 (SL-JID-1546)

GutoVeronezi
GutoVeronezi reviewed May 11, 2022
View reviewed changes
Comment thread core/src/main/java/com/cloud/agent/api/ModifyStoragePoolCommand.java Outdated
Comment thread ...ns/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/KVMStoragePoolManager.java Outdated
Comment thread ...o/src/main/java/org/apache/cloudstack/storage/datastore/client/ScaleIOGatewayClientImpl.java Outdated
Comment thread ...o/src/main/java/org/apache/cloudstack/storage/datastore/client/ScaleIOGatewayClientImpl.java Outdated
Comment thread .../main/java/org/apache/cloudstack/storage/datastore/driver/ScaleIOPrimaryDataStoreDriver.java
Comment thread ...java/org/apache/cloudstack/storage/datastore/lifecycle/ScaleIOPrimaryDataStoreLifeCycle.java Outdated
Comment thread ...leio/src/main/java/org/apache/cloudstack/storage/datastore/provider/ScaleIOHostListener.java Outdated
Comment thread ...leio/src/main/java/org/apache/cloudstack/storage/datastore/provider/ScaleIOHostListener.java Outdated
Comment thread ...leio/src/main/java/org/apache/cloudstack/storage/datastore/provider/ScaleIOHostListener.java Outdated
Comment thread ...e/volume/scaleio/src/main/java/org/apache/cloudstack/storage/datastore/util/ScaleIOUtil.java Outdated
DaanHoogland
DaanHoogland approved these changes May 16, 2022
View reviewed changes

@DaanHoogland DaanHoogland left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agree with mosat of @GutoVeronezi ś comments, but generally lgtm

@sureshanaparti
sureshanaparti force-pushed the seperate-host-network-support-for-scaleio-storage branch from b06b7e6 to 46b94ee Compare May 17, 2022 05:20
@sureshanaparti

sureshanaparti commented May 17, 2022

Copy link
Copy Markdown
Contributor Author

@GutoVeronezi thanks for the review. addressed the review comments, please check.

@sureshanaparti

sureshanaparti commented May 17, 2022

Copy link
Copy Markdown
Contributor Author

@blueorangutan package

@blueorangutan

blueorangutan commented May 17, 2022

Copy link
Copy Markdown

@sureshanaparti a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan

blueorangutan commented May 17, 2022

Copy link
Copy Markdown

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 3418

@sureshanaparti

sureshanaparti commented May 17, 2022

Copy link
Copy Markdown
Contributor Author

@blueorangutan test

@blueorangutan

blueorangutan commented Jun 20, 2022

Copy link
Copy Markdown

@sureshanaparti a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan

blueorangutan commented Jun 20, 2022

Copy link
Copy Markdown

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✖️ suse15. SL-JID 3593

@sureshanaparti

sureshanaparti commented Jun 20, 2022

Copy link
Copy Markdown
Contributor Author

@blueorangutan test

@blueorangutan

blueorangutan commented Jun 20, 2022

Copy link
Copy Markdown

@sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@yadvr yadvr added this to the 4.17.1.0 milestone Jun 20, 2022
@blueorangutan

blueorangutan commented Jun 20, 2022

Copy link
Copy Markdown

Trillian test result (tid-4338)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 36727 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6367-t4338-kvm-centos7.zip
Smoke tests completed. 98 look OK, 0 have errors
Only failed tests results shown below:

Test Result Time (s) Test File

@sureshanaparti
sureshanaparti force-pushed the seperate-host-network-support-for-scaleio-storage branch from 2de2248 to 9aafcc5 Compare June 21, 2022 04:30
@sureshanaparti
sureshanaparti changed the base branch from main to 4.17 June 21, 2022 04:31
@acs-robot

acs-robot commented Jun 21, 2022

Copy link
Copy Markdown

Found UI changes, kicking a new UI QA build
@blueorangutan ui

@blueorangutan

blueorangutan commented Jun 21, 2022

Copy link
Copy Markdown

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@sureshanaparti
sureshanaparti force-pushed the seperate-host-network-support-for-scaleio-storage branch from 9aafcc5 to 44d33ce Compare June 21, 2022 04:36
@sureshanaparti

sureshanaparti commented Jun 21, 2022

Copy link
Copy Markdown
Contributor Author

@blueorangutan package

@blueorangutan

blueorangutan commented Jun 21, 2022

Copy link
Copy Markdown

@sureshanaparti a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan

blueorangutan commented Jun 21, 2022

Copy link
Copy Markdown

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6367 (SL-JID-1786)

@sonarqubecloud

sonarqubecloud Bot commented Jun 21, 2022

Copy link
Copy Markdown

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 10 Code Smells

15.0% 15.0% Coverage
0.0% 0.0% Duplication

@blueorangutan

blueorangutan commented Jun 21, 2022

Copy link
Copy Markdown

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 3606

@yadvr

yadvr commented Jun 21, 2022

Copy link
Copy Markdown
Member

@blueorangutan test

@blueorangutan

blueorangutan commented Jun 21, 2022

Copy link
Copy Markdown

@rohityadavcloud a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan

blueorangutan commented Jun 21, 2022

Copy link
Copy Markdown

Trillian Build Failed (tid-4345)

@sureshanaparti

sureshanaparti commented Jun 21, 2022

Copy link
Copy Markdown
Contributor Author

@blueorangutan test

@blueorangutan

blueorangutan commented Jun 21, 2022

Copy link
Copy Markdown

@sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan

blueorangutan commented Jun 21, 2022

Copy link
Copy Markdown

Trillian test result (tid-4346)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 36917 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6367-t4346-kvm-centos7.zip
Smoke tests completed. 98 look OK, 0 have errors
Only failed tests results shown below:

Test Result Time (s) Test File

@yadvr
yadvr merged commit c70bc9d into apache:4.17 Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DaanHoogland DaanHoogland DaanHoogland approved these changes
@yadvr yadvr yadvr approved these changes
@harikrishna-patnala harikrishna-patnala Awaiting requested review from harikrishna-patnala
@nvazquez nvazquez Awaiting requested review from nvazquez
@GutoVeronezi GutoVeronezi Awaiting requested review from GutoVeronezi

Assignees

No one assigned

Labels

component:agent component:api component:build component:iscsi component:kvm component:managed-storage component:orchestration component:primary-storage component:storage distro:ubuntu

Projects

None yet

Milestone

4.17.1.0

Development

Successfully merging this pull request may close these issues.

6 participants

@sureshanaparti @blueorangutan @acs-robot @yadvr @DaanHoogland @GutoVeronezi