Fix VMware memory retrieval

[JoaoJandre]

Description

Currently memory usage statistics in VMware are inverted. It was discovered that during statistics collection, memory usage was collected and passed as free memory, so the memory usage graphs were inverted. The free memory calculation has been fixed and the memory statistics are now consistent with what is observed in VMware.

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

This was tested in a local lab, by creating a VM with VMware as its hypervisor and checking memory statistics in both vCenter and ACS.

[DaanHoogland]

clgtm

[acs-robot]

Found UI changes, kicking a new UI QA build
@blueorangutan ui

[blueorangutan]

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

[blueorangutan]

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6414 (SL-JID-1655)

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

0.0% Coverage
0.0% Duplication

[nvazquez]

Hi @JoaoJandre can you please target this PR to the 4.17 branch?

[GutoVeronezi]

LGTM

[yadvr]

@blueorangutan package

[yadvr]

@blueorangutan package

[blueorangutan]

@rohityadavcloud a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 3679

[sureshanaparti]

@blueorangutan test centos7 vmware-67u3

[blueorangutan]

@sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests

[blueorangutan]

Trillian Build Failed (tid-4412)

[sureshanaparti]

@blueorangutan test centos7 vmware-67u3

[blueorangutan]

@sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests

[blueorangutan]

Trillian Build Failed (tid-4414)

[sureshanaparti]

@blueorangutan package

[blueorangutan]

@sureshanaparti a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 3695

[sureshanaparti]

@blueorangutan test centos7 vmware-67u3

[blueorangutan]

@sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests

[blueorangutan]

Trillian test result (tid-4419)
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 38983 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6414-t4419-vmware-67u3.zip
Smoke tests completed. 98 look OK, 0 have errors
Only failed tests results shown below:

Test	Result	Time (s)	Test File