UI: add a provider for primary storage when adding zone wizard by utchoang · Pull Request #6429 · apache/cloudstack

utchoang · 2022-06-01T01:55:38Z

Description

This PR fixes #6088

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

acs-robot · 2022-06-01T01:56:40Z

Found UI changes, kicking a new UI QA build
@blueorangutan ui

blueorangutan · 2022-06-01T01:58:03Z

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan · 2022-06-01T02:06:41Z

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6429 (SL-JID-1646)

slavkap · 2022-06-02T12:36:00Z

Hi @utchoang, I think adding a custom protocol is needed for SolidFire and PowerFlex, and because the protocol parameter is set as mandatory

acs-robot · 2022-06-03T01:37:56Z

Found UI changes, kicking a new UI QA build
@blueorangutan ui

blueorangutan · 2022-06-03T01:39:03Z

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan · 2022-06-03T01:46:53Z

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6429 (SL-JID-1665)

sureshanaparti · 2022-06-03T05:34:49Z

Hi @utchoang, I think adding a custom protocol is needed for SolidFire and PowerFlex, and because the protocol parameter is set as mandatory

@utchoang Correct, protocol is the required input at UI, for adding primary storage. This is imp to pick the correct storage provider, url and related parameter inputs. If custom protocol for PowerFlex is confusing, this can be updated to something meaningful, eg. PreSetup or PowerFlex (now or can be re-visited later ?), but ensure that all the provider details are properly picked and passed to the API call. Also, it's better to keep adding primary storage options in sync, at zone wizard and add primary storage dialog. Check if any documentation update needed for these changes. Thanks.

utchoang · 2022-06-03T06:05:35Z

@slavkap @sureshanaparti Thank you for your comments. I fixed it, please review it again.

slavkap · 2022-06-07T08:48:06Z

Hi @utchoang, I think it will be more user-friendly if the custom protocol option is shown with the rest of the protocol options. Because we fill in the form sequentially, the provider, in this case, should be above the protocol, or the custom option should be in the list of protocols. Another option when you choose PowerFlex/SolidFire, the custom protocol could be automatically set.
Also, I think that it's not a good idea to limit the custom option only to SolidFire/PowerFlex (e.g. Datera plugin also is using this option, probably there are other storage plugins even such not in CS upstream but have integrations with CS)

…l options

acs-robot · 2022-06-07T09:07:11Z

Found UI changes, kicking a new UI QA build
@blueorangutan ui

blueorangutan · 2022-06-07T09:08:03Z

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan · 2022-06-07T09:23:26Z

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6429 (SL-JID-1687)

sureshanaparti · 2022-06-07T11:00:53Z

@utchoang Sometimes 'Protocol' is cleared when 'Provider' is selected, please check.

acs-robot · 2022-06-08T01:35:06Z

Found UI changes, kicking a new UI QA build
@blueorangutan ui

blueorangutan · 2022-06-08T01:36:03Z

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan · 2022-06-08T01:43:26Z

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6429 (SL-JID-1689)

slavkap

Hi @utchoang, here

cloudstack/ui/src/views/infra/zone/ZoneWizardLaunchZone.vue

Line 1327 in d815b9c

} else if (protocol === 'SharedMountPoint') {

if it's SharedMountPoint, the server should be set to server = 'localhost' because it's not provided by default

acs-robot · 2022-06-08T09:47:59Z

Found UI changes, kicking a new UI QA build
@blueorangutan ui

blueorangutan · 2022-06-08T09:49:02Z

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan · 2022-06-08T09:56:03Z

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6429 (SL-JID-1693)

slavkap

Thanks, @utchoang, for the PR!
code LGTM tested it with SharedMoutPoint and StorPool

sonarqubecloud · 2022-06-08T10:48:42Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

…e#6429) Fixes apache#6088 * add provider in creating primary storage when adding new zone * add custom protocol for SolidFire/PowerFlex provider * set the custom protocol option available with the rest of the protocol options * fixes indexOf error & auto-select protocol * set server=localhost with SharedMountPoint protocol

add provider in creating primary storage when adding new zone

731f0ca

boring-cyborg Bot added the component:UI label Jun 1, 2022

nvazquez added this to the 4.17.1.0 milestone Jun 2, 2022

add custom protocol for SolidFire/PowerFlex provider

6a9f247

nvazquez force-pushed the main branch from c56220f to 0f4c3af Compare June 6, 2022 15:14

set the custom protocol option available with the rest of the protoco…

f2fb207

…l options

fixes indexOf error & auto-select protocol

d815b9c

slavkap requested changes Jun 8, 2022

View reviewed changes

set server=localhost with SharedMountPoint protocol

c787bdb

slavkap approved these changes Jun 8, 2022

View reviewed changes

shwstppr approved these changes Jun 20, 2022

View reviewed changes

yadvr merged commit d6488c5 into apache:main Jun 20, 2022

Conversation

utchoang commented Jun 1, 2022

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

Uh oh!

acs-robot commented Jun 1, 2022

Uh oh!

blueorangutan commented Jun 1, 2022

Uh oh!

blueorangutan commented Jun 1, 2022

Uh oh!

slavkap commented Jun 2, 2022

Uh oh!

acs-robot commented Jun 3, 2022

Uh oh!

blueorangutan commented Jun 3, 2022

Uh oh!

blueorangutan commented Jun 3, 2022

Uh oh!

sureshanaparti commented Jun 3, 2022

Uh oh!

utchoang commented Jun 3, 2022

Uh oh!

slavkap commented Jun 7, 2022

Uh oh!

acs-robot commented Jun 7, 2022

Uh oh!

blueorangutan commented Jun 7, 2022

Uh oh!

blueorangutan commented Jun 7, 2022

Uh oh!

sureshanaparti commented Jun 7, 2022

Uh oh!

acs-robot commented Jun 8, 2022

Uh oh!

blueorangutan commented Jun 8, 2022

Uh oh!

blueorangutan commented Jun 8, 2022

Uh oh!

slavkap left a comment

Choose a reason for hiding this comment

Uh oh!

acs-robot commented Jun 8, 2022

Uh oh!

blueorangutan commented Jun 8, 2022

Uh oh!

blueorangutan commented Jun 8, 2022

Uh oh!

slavkap left a comment

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud Bot commented Jun 8, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants