Skip to content

UI: Hide project delete button while in this project view - #6439

Merged
nvazquez merged 1 commit into
apache:4.17from
EWERK-DIGITAL:feature/hidden-delete-project-with-projectview
Jun 8, 2022
Merged

nvazquez merged 1 commit into
apache:4.17from
EWERK-DIGITAL:feature/hidden-delete-project-with-projectview

Conversation

@utchoang

@utchoang utchoang commented Jun 6, 2022

Copy link
Copy Markdown

Description

This PR for hiding project delete button while in this project view

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

image

How Has This Been Tested?

@utchoang utchoang mentioned this pull request Jun 6, 2022
8 tasks
@acs-robot

Copy link
Copy Markdown

Found UI changes, kicking a new UI QA build
@blueorangutan ui

@blueorangutan

Copy link
Copy Markdown

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6439 (SL-JID-1682)

@nvazquez nvazquez added this to the 4.17.1.0 milestone Jun 8, 2022
@nvazquez
nvazquez changed the base branch from main to 4.17 June 8, 2022 01:08

@nvazquez nvazquez left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@weizhouapache weizhouapache left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

@nvazquez
nvazquez merged commit 22c4836 into apache:4.17 Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants