Skip to content

UI: fix create vpc private gw by regular users - #6445

Merged
nvazquez merged 1 commit into
apache:4.17from
weizhouapache:4.17-fix-user-create-privategw
Jun 9, 2022
Merged

nvazquez merged 1 commit into
apache:4.17from
weizhouapache:4.17-fix-user-create-privategw

Conversation

@weizhouapache

Copy link
Copy Markdown
Member

Description

This PR fixes an regression issue of #6400

Ths issue is, the associated network is always required, even when a network is selected from the drop down, which cause regular users arenot able to create private gateway with associated network.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

@weizhouapache
weizhouapache changed the base branch from main to 4.17 June 8, 2022 14:46
@weizhouapache weizhouapache added this to the 4.17.1.0 milestone Jun 8, 2022
@acs-robot

Copy link
Copy Markdown

Found UI changes, kicking a new UI QA build
@blueorangutan ui

@blueorangutan

Copy link
Copy Markdown

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6445 (SL-JID-1697)

@sonarqubecloud

sonarqubecloud Bot commented Jun 8, 2022

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sureshanaparti sureshanaparti left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@nvazquez
nvazquez merged commit d45d257 into apache:4.17 Jun 9, 2022
@weizhouapache
weizhouapache deleted the 4.17-fix-user-create-privategw branch December 9, 2022 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants