Skip to content

api: Add vpc name and uuid to VMs list response (nics) and nics response - #6461

Merged
yadvr merged 1 commit into
apache:4.17from
shapeblue:add-vpc-info-to-vms-nics
Jun 16, 2022
Merged

yadvr merged 1 commit into
apache:4.17from
shapeblue:add-vpc-info-to-vms-nics

Conversation

@Pearl1594

Copy link
Copy Markdown
Contributor

Description

This PR adds vpc info to the nics response as part of list VMs response and list nics response
Addresses: #6452

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Screenshots (if appropriate):

How Has This Been Tested?

listed VMs and nics for a VM belonging to a VPC network:

(localcloud) 🐱 > list virtualmachines id=9c762cf8-7742-48df-bc57-43bf126d3471 filter=nic,
{
  "count": 1,
  "virtualmachine": [
    {
      "nic": [
        {
          "broadcasturi": "vlan://167",
          "deviceid": "0",
          "extradhcpoption": [],
          "gateway": "10.10.10.1",
          "id": "a703d827-4b5a-46e4-b9ea-8cd2aaafbc26",
          "ipaddress": "10.10.10.66",
          "isdefault": true,
          "isolationuri": "vlan://167",
          "macaddress": "02:00:28:aa:00:01",
          "netmask": "255.255.255.0",
          "networkid": "02ad6bac-1cd6-461a-a951-8934bffd4eb9",
          "networkname": "n1",
          "secondaryip": [],
          "traffictype": "Guest",
          "type": "Isolated",
          "vpcid": "e74c44c9-aad7-4c0e-adbe-912d980c2f28",
          "vpcname": "v1"
        }
      ]
    }
  ]
}

@Pearl1594

Copy link
Copy Markdown
Contributor Author

@blueorangutan package

@blueorangutan

Copy link
Copy Markdown

@Pearl1594 a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@sonarqubecloud

Copy link
Copy Markdown

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@nvazquez nvazquez added this to the 4.17.1.0 milestone Jun 15, 2022
@blueorangutan

Copy link
Copy Markdown

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 3575

@nvazquez

Copy link
Copy Markdown
Contributor

@blueorangutan test

@blueorangutan

Copy link
Copy Markdown

@nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@nvazquez nvazquez linked an issue Jun 16, 2022 that may be closed by this pull request
@blueorangutan

Copy link
Copy Markdown

Trillian test result (tid-4324)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 36125 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6461-t4324-kvm-centos7.zip
Smoke tests completed. 98 look OK, 0 have errors
Only failed tests results shown below:

Test Result Time (s) Test File

@yadvr
yadvr merged commit 1b71696 into apache:4.17 Jun 16, 2022
utchoang pushed a commit to EWERK-DIGITAL/cloudstack that referenced this pull request Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

API: virtualmachine VPC information not returned

4 participants