Skip to content

UI: Fixes UI break with SAML authentication - #6462

Merged
yadvr merged 1 commit into
apache:4.17from
EWERK-DIGITAL:feature/fix-ui-error-with-saml-login
Jun 20, 2022
Merged

UI: Fixes UI break with SAML authentication#6462
yadvr merged 1 commit into
apache:4.17from
EWERK-DIGITAL:feature/fix-ui-error-with-saml-login

Conversation

@utchoang

@utchoang utchoang commented Jun 16, 2022 •
edited
Loading

Copy link
Copy Markdown

Description

This PR for fixes #6459

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

@acs-robot

acs-robot commented Jun 16, 2022

Copy link
Copy Markdown

Found UI changes, kicking a new UI QA build
@blueorangutan ui

@blueorangutan

blueorangutan commented Jun 16, 2022

Copy link
Copy Markdown

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan

blueorangutan commented Jun 16, 2022

Copy link
Copy Markdown

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6462 (SL-JID-1743)

@yadvr yadvr added this to the 4.17.1.0 milestone Jun 16, 2022
@yadvr
yadvr changed the base branch from main to 4.17 June 16, 2022 08:03
@yadvr

yadvr commented Jun 16, 2022

Copy link
Copy Markdown
Member

@utchoang can you rebase/change base of the PR branch to 4.17, as this needs fixing in 4.17.1.0

@utchoang
utchoang force-pushed the 4.17 branch 4 times, most recently from 4bf2f2b to 1b71696 Compare June 16, 2022 11:01
@acs-robot

acs-robot commented Jun 17, 2022

Copy link
Copy Markdown

Found UI changes, kicking a new UI QA build
@blueorangutan ui

@blueorangutan

blueorangutan commented Jun 17, 2022

Copy link
Copy Markdown

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@utchoang utchoang closed this Jun 17, 2022
@utchoang
utchoang force-pushed the feature/fix-ui-error-with-saml-login branch from 1d3d4f9 to 7ed8d54 Compare June 17, 2022 01:35
@utchoang utchoang reopened this Jun 17, 2022
@blueorangutan

blueorangutan commented Jun 17, 2022

Copy link
Copy Markdown

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6462 (SL-JID-1750)

@acs-robot

acs-robot commented Jun 17, 2022

Copy link
Copy Markdown

Found UI changes, kicking a new UI QA build
@blueorangutan ui

1 similar comment
@acs-robot

acs-robot commented Jun 17, 2022

Copy link
Copy Markdown

Found UI changes, kicking a new UI QA build
@blueorangutan ui

@blueorangutan

blueorangutan commented Jun 17, 2022

Copy link
Copy Markdown

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan

blueorangutan commented Jun 17, 2022

Copy link
Copy Markdown

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6462 (SL-JID-1751)

@sonarqubecloud

sonarqubecloud Bot commented Jun 17, 2022

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@nvazquez nvazquez mentioned this pull request Jun 17, 2022
Closed
@kohrar

kohrar commented Jun 17, 2022

Copy link
Copy Markdown
Contributor

Awesome work. Thanks @utchoang for the quick fix.

@yadvr
yadvr requested review from nvazquez and shwstppr June 19, 2022 08:05
shwstppr
shwstppr reviewed Jun 20, 2022
View reviewed changes

@shwstppr shwstppr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM

@yadvr
yadvr merged commit c6f12f3 into apache:4.17 Jun 20, 2022
yadvr pushed a commit that referenced this pull request Jul 18, 2022
Hoang Nguyen @yadvr
ui: add a default value for customColumns (#6462)
5bc7024 
Fixes #6459

(cherry picked from commit c6f12f3)
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shwstppr shwstppr shwstppr left review comments
@yadvr yadvr yadvr approved these changes
@nvazquez nvazquez Awaiting requested review from nvazquez

Assignees

No one assigned

Labels

component:agent component:api component:build component:database component:orchestration component:storage component:UI distro:ubuntu

Projects

None yet

Milestone

4.17.1.0

Development

Successfully merging this pull request may close these issues.

UI breaks with SAML authentication

6 participants

@utchoang @acs-robot @blueorangutan @yadvr @kohrar @shwstppr