Skip to content

UI: Fixes ui error when upgrade virtual routers from virtual router list - #6468

Merged
yadvr merged 1 commit into
apache:4.17from
EWERK-DIGITAL:feature/fix-ui-error-update-template-vitual-router
Jun 20, 2022
Merged

yadvr merged 1 commit into
apache:4.17from
EWERK-DIGITAL:feature/fix-ui-error-update-template-vitual-router

Conversation

@utchoang

@utchoang utchoang commented Jun 17, 2022

Copy link
Copy Markdown

Description

This PR fixes #6466

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

@utchoang
utchoang changed the base branch from main to 4.17 June 17, 2022 01:55
@acs-robot

Copy link
Copy Markdown

Found UI changes, kicking a new UI QA build
@blueorangutan ui

@blueorangutan

Copy link
Copy Markdown

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6468 (SL-JID-1752)

@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@utchoang

utchoang commented Jun 17, 2022

Copy link
Copy Markdown
Author

I see the response of upgradeRouterTemplate API does not contain the jobId but adds 1 more level of asyncjobs so the upgrade is still in the progress state. (below image)
image
image

@nvazquez nvazquez added this to the 4.17.1.0 milestone Jun 17, 2022

@weizhouapache weizhouapache left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kohrar

kohrar commented Jun 17, 2022

Copy link
Copy Markdown
Contributor

The fix seems to work for me. Thanks @utchoang

@yadvr
yadvr merged commit 15c4dcf into apache:4.17 Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

UI - Cannot mass upgrade virtual routers from virtual router list

8 participants