Skip to content

kvm: upgrade libvirt-java to v0.5.3 - #6472

Merged
yadvr merged 2 commits into
apache:4.17from
shapeblue:libvirt-java-deps-upgrade
Jun 22, 2022
Merged

yadvr merged 2 commits into
apache:4.17from
shapeblue:libvirt-java-deps-upgrade

Conversation

@yadvr

@yadvr yadvr commented Jun 17, 2022

Copy link
Copy Markdown
Member

Reference: https://gitlab.com/libvirt/libvirt-java/-/issues/6

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Reference: https://gitlab.com/libvirt/libvirt-java/-/issues/6

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
@yadvr

yadvr commented Jun 17, 2022

Copy link
Copy Markdown
Member Author

@yadvr yadvr closed this Jun 20, 2022
@yadvr yadvr reopened this Jun 20, 2022

@sureshanaparti sureshanaparti left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
@acs-robot

Copy link
Copy Markdown

Found UI changes, kicking a new UI QA build
@blueorangutan ui

@blueorangutan

Copy link
Copy Markdown

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@yadvr

yadvr commented Jun 20, 2022

Copy link
Copy Markdown
Member Author

@blueorangutan package

@blueorangutan

Copy link
Copy Markdown

@rohityadavcloud a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6472 (SL-JID-1780)

@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@GabrielBrascher GabrielBrascher left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rohityadavcloud I assume that we should merge only when it is synced in https://mvnrepository.com/artifact/org.libvirt/libvirt.

LGTM, looking forward for libvirt-java 0.5.3 😃

@blueorangutan

Copy link
Copy Markdown

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 3600

@yadvr

yadvr commented Jun 21, 2022

Copy link
Copy Markdown
Member Author

@GabrielBrascher not necessary, if the upstream project publishes their own repo, we can add it in pom.xml.

Comment thread pom.xml
</repository>
<repository>
<id>libvirt.org.maven2</id>
<url>https://libvirt.org/maven2/</url>

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @GabrielBrascher I've added libvirt's maven repo here from which the version is available.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect @rohityadavcloud, thanks!

@yadvr

yadvr commented Jun 21, 2022

Copy link
Copy Markdown
Member Author

@blueorangutan test

@blueorangutan

Copy link
Copy Markdown

@rohityadavcloud a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan

Copy link
Copy Markdown

Trillian test result (tid-4344)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 37111 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6472-t4344-kvm-centos7.zip
Smoke tests completed. 98 look OK, 0 have errors
Only failed tests results shown below:

Test Result Time (s) Test File

@harikrishna-patnala harikrishna-patnala left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT

@yadvr
yadvr merged commit f818ecc into apache:4.17 Jun 22, 2022
@yadvr
yadvr deleted the libvirt-java-deps-upgrade branch June 22, 2022 13:13
GabrielBrascher pushed a commit to GabrielBrascher/cloudstack that referenced this pull request Jun 27, 2022
* kvm: upgrade libvirt-java to v0.5.3
* add libvirt.org maven repo

Reference: https://gitlab.com/libvirt/libvirt-java/-/issues/6

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants