Skip to content

UI: fix create tags for LB rules - #6475

Merged
weizhouapache merged 1 commit into
apache:4.17from
weizhouapache:4.17-fix-lb-rules-create-tags
Jun 27, 2022
Merged

weizhouapache merged 1 commit into
apache:4.17from
weizhouapache:4.17-fix-lb-rules-create-tags

Conversation

@weizhouapache

Copy link
Copy Markdown
Member

Description

This PR fixes the issue when create tags for load balancing rules.

without this change
image

with this change it works.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

@acs-robot

Copy link
Copy Markdown

Found UI changes, kicking a new UI QA build
@blueorangutan ui

@blueorangutan

Copy link
Copy Markdown

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@utchoang utchoang left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM!

@blueorangutan

Copy link
Copy Markdown

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6475 (SL-JID-1773)

@nvazquez nvazquez added this to the 4.17.1.0 milestone Jun 20, 2022
@weizhouapache
weizhouapache merged commit dd3bd21 into apache:4.17 Jun 27, 2022
weizhouapache added a commit that referenced this pull request Oct 7, 2022
Port following changes
1. UI: fix create tags for LB rules (#6475)
2. AS UI: fix 'missing methodname' when create sticky policy
3. AS UI: fix sticky name is required when methodname is 'none'
@weizhouapache
weizhouapache deleted the 4.17-fix-lb-rules-create-tags branch December 9, 2022 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants