Skip to content

Fix rpfilter config values from integer to boolean on upgrade path - #6477

Merged
nvazquez merged 3 commits into
apache:4.17from
shapeblue:fixrpfiltercfgvalue
Jun 23, 2022
Merged

nvazquez merged 3 commits into
apache:4.17from
shapeblue:fixrpfiltercfgvalue

Conversation

@nvazquez

@nvazquez nvazquez commented Jun 20, 2022

Copy link
Copy Markdown
Contributor

Description

This PR updates the config values for network.disable.rpfilter and consoleproxy.disable.rpfilter to meet the boolean type set on #6380.
Fixes: #6390

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Upgrade from 4.16.1 successfully:

Before upgrade: Changed only one value, leave the other as default

MariaDB [cloud]> select name, value from configuration where name like '%rpfilter';
+-------------------------------+-------+
| name                          | value |
+-------------------------------+-------+
| consoleproxy.disable.rpfilter | 2     |
| network.disable.rpfilter      | true  |
+-------------------------------+-------+
2 rows in set (0.00 sec)

MariaDB [cloud]> select * from version order by id desc limit 1;
+----+----------+---------------------+----------+
| id | version  | updated             | step     |
+----+----------+---------------------+----------+
| 37 | 4.16.1.0 | 2022-06-20 11:49:40 | Complete |
+----+----------+---------------------+----------+
1 row in set (0.00 sec)

After the upgrade: only the integer value is properly updated, as expected

MariaDB [cloud]> select name, value from configuration where name like '%rpfilter';
+-------------------------------+-------+
| name                          | value |
+-------------------------------+-------+
| consoleproxy.disable.rpfilter | false |
| network.disable.rpfilter      | true  |
+-------------------------------+-------+
2 rows in set (0.00 sec)

MariaDB [cloud]> select * from version order by id desc limit 1;
+----+----------+---------------------+----------+
| id | version  | updated             | step     |
+----+----------+---------------------+----------+
| 39 | 4.17.1.0 | 2022-06-23 12:14:14 | Complete |
+----+----------+---------------------+----------+
1 row in set (0.00 sec)

@nvazquez

Copy link
Copy Markdown
Contributor Author

@blueorangutan package

@blueorangutan

Copy link
Copy Markdown

@nvazquez a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 3603

@nvazquez

Copy link
Copy Markdown
Contributor Author

@blueorangutan test

@blueorangutan

Copy link
Copy Markdown

@nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan

Copy link
Copy Markdown

Trillian test result (tid-4343)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 37674 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6477-t4343-kvm-centos7.zip
Smoke tests completed. 98 look OK, 0 have errors
Only failed tests results shown below:

Test Result Time (s) Test File

Comment thread engine/schema/src/main/resources/META-INF/db/schema-41700to41710.sql Outdated
…10.sql

Co-authored-by: Suresh Kumar Anaparti <sureshkumar.anaparti@gmail.com>
Comment thread engine/schema/src/main/resources/META-INF/db/schema-41700to41710.sql Outdated

@weizhouapache weizhouapache left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

@DaanHoogland

Copy link
Copy Markdown
Contributor

¿ any testing needed @nvazquez ?

@nvazquez

Copy link
Copy Markdown
Contributor Author

@DaanHoogland I have now included the upgrade testing on the PR description, thanks for the review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Updating the rpfilter config value to 'false' in the upgrade path

7 participants