UI: Fixes some issues from zone wizard with VMWare hypervisor by utchoang · Pull Request #6480 · apache/cloudstack

utchoang · 2022-06-21T09:24:57Z

Description

This PR for fixes some issues from zone wizard with VMWare hypervisor (#6479)

Hide the warning HTML in the message when using vue-i18n
Hide IP address step with VMWare hypervisor
Fill the value of input on the edit tariff label form
Close edit tariff label modal when clicking icon-close
Auto change cluster name if submit error with VMWare hypervisor

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

acs-robot · 2022-06-21T09:26:04Z

Found UI changes, kicking a new UI QA build
@blueorangutan ui

blueorangutan · 2022-06-21T09:27:03Z

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan · 2022-06-21T09:40:54Z

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6480 (SL-JID-1788)

utchoang · 2022-06-21T10:02:01Z

@blueorangutan ui

acs-robot · 2022-06-21T10:02:06Z

Found UI changes, kicking a new UI QA build
@blueorangutan ui

blueorangutan · 2022-06-21T10:03:05Z

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan · 2022-06-21T10:12:19Z

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6480 (SL-JID-1790)

acs-robot · 2022-06-22T01:11:34Z

Found UI changes, kicking a new UI QA build
@blueorangutan ui

blueorangutan · 2022-06-22T01:12:03Z

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan · 2022-06-22T01:19:13Z

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6480 (SL-JID-1800)

acs-robot · 2022-06-22T01:22:31Z

Found UI changes, kicking a new UI QA build
@blueorangutan ui

blueorangutan · 2022-06-22T01:23:02Z

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan · 2022-06-22T01:29:50Z

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6480 (SL-JID-1801)

acs-robot · 2022-06-22T09:18:34Z

Found UI changes, kicking a new UI QA build
@blueorangutan ui

blueorangutan · 2022-06-22T09:19:03Z

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan · 2022-06-22T09:19:03Z

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

acs-robot · 2022-06-22T09:26:27Z

Found UI changes, kicking a new UI QA build
@blueorangutan ui

blueorangutan · 2022-06-22T09:27:02Z

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan · 2022-06-22T09:39:01Z

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6480 (SL-JID-1808)

borisstoyanov · 2022-06-23T11:01:58Z

@blueorangutan help

blueorangutan · 2022-06-23T11:03:02Z

@borisstoyanov I understand these words: "help", "hello", "thanks", "package", "test"
Test command usage: test [mgmt os] [hypervisor] [keepEnv]
Mgmt OS options: ['centos7', 'centos6', 'suse15', 'alma8', 'ubuntu18', 'ubuntu22', 'ubuntu20', 'rocky8']
Hypervisor options: ['kvm-centos6', 'kvm-centos7', 'kvm-rocky8', 'kvm-alma8', 'kvm-ubuntu18', 'kvm-ubuntu20', 'kvm-ubuntu22', 'kvm-suse15', 'vmware-55u3', 'vmware-60u2', 'vmware-65u2', 'vmware-67u3', 'vmware-70u1', 'vmware-70u2', 'vmware-70u3', 'xenserver-65sp1', 'xenserver-71', 'xenserver-74', 'xcpng74', 'xcpng76', 'xcpng80', 'xcpng81', 'xcpng82']
Note: when keepEnv is passed, you need to specify mgmt server os and hypervisor or use the matrix command.
Package command usage: package [all(default value),kvm,xen,vmware,hyperv,ovm] - a comma separated list can be passed with package command to bundle the required hypervisor's systemVM templates. Not passing any argument will bundle all - kvm,xen and vmware templates.

Blessed contributors for kicking Trillian test jobs: ['rohityadavcloud', 'nvazquez', 'borisstoyanov', 'DaanHoogland', 'shwstppr', 'andrijapanicsb', 'Pearl1594', 'davidjumani', 'harikrishna-patnala', 'vladimirpetrov', 'sureshanaparti', 'weizhouapache', 'NuxRo']

borisstoyanov · 2022-06-23T11:03:09Z

@blueorangutan package

blueorangutan · 2022-06-23T11:04:03Z

@borisstoyanov a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2022-06-23T12:09:31Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 3637

borisstoyanov · 2022-06-24T07:45:05Z

@blueorangutan test centos7 vmware-70u3 keepEnv

blueorangutan · 2022-06-24T07:46:03Z

@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + vmware-70u3) has been kicked to run smoke tests

blueorangutan · 2022-06-24T19:28:43Z

Trillian test result (tid-4368)
Environment: vmware-70u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 40663 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6480-t4368-vmware-70u3.zip
Smoke tests completed. 98 look OK, 0 have errors
Only failed tests results shown below:

Test	Result	Time (s)	Test File

yadvr

LGTM didn't test it though

shwstppr

Tested basic flow in zone wizard and add cluster form

harikrishna-patnala · 2022-07-08T08:05:46Z

@utchoang regarding the add cluster form, are you trying to fix the case where cluster name is getting appended on every error ? I still see the name getting appended after the fix too. Please correct me if I'm wrong

harikrishna-patnala · 2022-07-08T08:13:20Z

@utchoang looks like it is not applied properly on the qa setup. I've tested it with my environment and looks good.

hide html warning in message

cae1b3a

boring-cyborg Bot added the component:UI label Jun 21, 2022

utchoang mentioned this pull request Jun 21, 2022

No input filed for IP address in UI when adding new Zone. #6479

Closed

hidden ip address step

70dea70

nvazquez added this to the 4.17.1.0 milestone Jun 21, 2022

nvazquez added the type:bug label Jun 21, 2022

nvazquez requested review from Pearl1594, shwstppr and weizhouapache June 21, 2022 17:28

refill value of edit tariff

a033f0f

apache deleted a comment from blueorangutan Jun 22, 2022

close modal when icon-close clicked

a0f7115

utchoang changed the title ~~UI: Hide html warning in message~~ UI: Fixes some issues from zone wizard with VMWare hypervisor Jun 22, 2022

apache deleted a comment from blueorangutan Jun 22, 2022

fixes modal not show when error

0270f1a

remove automatic change clustername

2666780

apache deleted a comment from blueorangutan Jun 22, 2022

nvazquez added the component:vmware label Jun 23, 2022

yadvr assigned borisstoyanov and harikrishna-patnala Jun 30, 2022

utchoang mentioned this pull request Jul 6, 2022

When creating a new zone, the host password field should not be required when an SSH key is being used #6499

Closed

yadvr approved these changes Jul 6, 2022

View reviewed changes

shwstppr approved these changes Jul 8, 2022

View reviewed changes

harikrishna-patnala approved these changes Jul 8, 2022

View reviewed changes

harikrishna-patnala merged commit 600d81e into apache:4.17 Jul 8, 2022

utchoang mentioned this pull request Jul 26, 2022

Create a zone wizard freeze after vCenter information screen #6568

Closed

Conversation

utchoang commented Jun 21, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

Uh oh!

acs-robot commented Jun 21, 2022

Uh oh!

blueorangutan commented Jun 21, 2022

Uh oh!

blueorangutan commented Jun 21, 2022

Uh oh!

utchoang commented Jun 21, 2022

Uh oh!

acs-robot commented Jun 21, 2022

Uh oh!

blueorangutan commented Jun 21, 2022

Uh oh!

blueorangutan commented Jun 21, 2022

Uh oh!

acs-robot commented Jun 22, 2022

Uh oh!

blueorangutan commented Jun 22, 2022

Uh oh!

blueorangutan commented Jun 22, 2022

Uh oh!

acs-robot commented Jun 22, 2022

Uh oh!

blueorangutan commented Jun 22, 2022

Uh oh!

blueorangutan commented Jun 22, 2022

Uh oh!

acs-robot commented Jun 22, 2022

Uh oh!

blueorangutan commented Jun 22, 2022

Uh oh!

blueorangutan commented Jun 22, 2022

Uh oh!

acs-robot commented Jun 22, 2022

Uh oh!

blueorangutan commented Jun 22, 2022

Uh oh!

blueorangutan commented Jun 22, 2022

Uh oh!

borisstoyanov commented Jun 23, 2022

Uh oh!

blueorangutan commented Jun 23, 2022

Uh oh!

borisstoyanov commented Jun 23, 2022

Uh oh!

blueorangutan commented Jun 23, 2022

Uh oh!

blueorangutan commented Jun 23, 2022

Uh oh!

borisstoyanov commented Jun 24, 2022

Uh oh!

blueorangutan commented Jun 24, 2022

Uh oh!

blueorangutan commented Jun 24, 2022

Uh oh!

yadvr left a comment

Choose a reason for hiding this comment

Uh oh!

shwstppr left a comment

Choose a reason for hiding this comment

Uh oh!

harikrishna-patnala commented Jul 8, 2022

Uh oh!

harikrishna-patnala commented Jul 8, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

utchoang commented Jun 21, 2022 •

edited

Loading