Fix for VMware VM migration with volume in local storage by harikrishna-patnala · Pull Request #6483 · apache/cloudstack

harikrishna-patnala · 2022-06-22T06:35:18Z

Description

This PR fixes issue #6270 where VMmigration along with volumes API fails in case of local storage in VMware.

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

Create a VM with root disk and data disk, make sure disks are created in local storage
Stop the VM
From UI/API migrate the VM along with disks to a different local storage.
Migration is successful after this fix.

acs-robot · 2022-06-22T06:36:14Z

Found UI changes, kicking a new UI QA build
@blueorangutan ui

blueorangutan · 2022-06-22T06:37:02Z

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan · 2022-06-22T06:37:03Z

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

yadvr · 2022-06-22T06:44:16Z

Thanks @harikrishna-patnala for the bugfix PR, should this be raised for 4.17 branch?

blueorangutan · 2022-06-22T06:55:19Z

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6483 (SL-JID-1806)

blueorangutan · 2022-06-22T07:00:16Z

UI build: ✖️
(SL-JID-10)

harikrishna-patnala · 2022-06-22T07:20:42Z

Thanks @harikrishna-patnala for the bugfix PR, should this be raised for 4.17 branch?

Yes @rohityadavcloud , changed the base branch to 4.17. Thanks

shwstppr

code lgtm, one minor comment

shwstppr · 2022-06-22T08:42:04Z

+        for (Map.Entry<Volume, StoragePool> entry : volumeToPool.entrySet()) {
+            Volume volume = entry.getKey();
+            StoragePool pool = entry.getValue();
+            if (volume.getVolumeType().equals(Volume.Type.ROOT) && pool.isLocal()) {
+                List<StoragePoolHostVO> storagePoolHostVOs = storagePoolHostDao.listByPoolId(pool.getId());
+                StoragePoolHostVO storagePoolHostVO = storagePoolHostVOs.get(0);
+                HostVO hostVO = _hostDao.findById(storagePoolHostVO.getHostId());
+                hostGuidInTargetCluster = hostVO.getGuid();
+            }
+        }


@harikrishna-patnala do we need to continue traversing through all entries, we can return the first found?

Yes @shwstppr, added a break. Thanks.

shwstppr · 2022-06-22T09:16:46Z

@blueorangutan package

blueorangutan · 2022-06-22T09:17:03Z

@shwstppr a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2022-06-22T09:17:03Z

@shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2022-06-22T10:51:09Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 3626

blueorangutan · 2022-06-22T10:51:27Z

Packaging result: ✖️ el7 ✖️ el8 ✖️ debian ✖️ suse15. SL-JID 8

harikrishna-patnala · 2022-06-27T10:06:13Z

Addressed the review comments @sureshanaparti, please review

acs-robot · 2022-06-27T10:06:37Z

Found UI changes, kicking a new UI QA build
@blueorangutan ui

blueorangutan · 2022-06-27T10:07:02Z

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan · 2022-06-27T10:13:22Z

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6483 (SL-JID-1849)

sureshanaparti

code LGTM

DaanHoogland · 2022-06-27T14:07:14Z

SonarCloud Quality Gate failed.

0 Bugs 0 Vulnerabilities 0 Security Hotspots 2 Code Smells

0.0% Coverage 0.0% Duplication

please have a look at those @harikrishna-patnala , they make sense.

acs-robot · 2022-06-28T07:16:23Z

Found UI changes, kicking a new UI QA build
@blueorangutan ui

blueorangutan · 2022-06-28T07:17:03Z

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan · 2022-06-28T07:29:55Z

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6483 (SL-JID-1860)

acs-robot · 2022-06-28T07:50:03Z

Found UI changes, kicking a new UI QA build
@blueorangutan ui

acs-robot · 2022-06-28T08:01:44Z

Found UI changes, kicking a new UI QA build
@blueorangutan ui

blueorangutan · 2022-06-28T08:02:03Z

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan · 2022-06-28T08:08:50Z

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6483 (SL-JID-1862)

sureshanaparti · 2022-06-28T08:09:07Z

@blueorangutan package

blueorangutan · 2022-06-28T08:10:03Z

@sureshanaparti a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2022-06-28T09:09:09Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 3663

sonarqubecloud · 2022-06-28T09:12:26Z

SonarCloud Quality Gate failed.

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

0.0% Coverage
0.0% Duplication

DaanHoogland

clgtm

DaanHoogland · 2022-06-28T09:22:50Z

    private String getTargetHostGuid(StoragePool targetLocalPoolForVM, Long destClusterId, boolean isInterClusterMigration) {
        String targetHostGuid = null;
        if (targetLocalPoolForVM != null) {
+            // Get the target host for local storage migration


😁 this comment says kind of exactly what the code line below says as well. not sure we need it, but hey ...

yadvr · 2022-06-30T06:09:44Z

@blueorangutan test centos7 vmware-67u3

blueorangutan · 2022-06-30T06:10:03Z

@rohityadavcloud a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests

blueorangutan · 2022-06-30T17:34:44Z

Trillian test result (tid-4409)
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 39824 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6483-t4409-vmware-67u3.zip
Smoke tests completed. 98 look OK, 0 have errors
Only failed tests results shown below:

Test	Result	Time (s)	Test File

sureshanaparti · 2022-07-01T05:08:35Z

Merging this based on the approvals, and test results.

boring-cyborg Bot added component:api component:management-server component:storage component:vmware labels Jun 22, 2022

harikrishna-patnala force-pushed the VMwareVMMigrationWithVolumeInLocalStorage branch from be57f6a to a1cbe0f Compare June 22, 2022 06:37

harikrishna-patnala requested a review from shwstppr June 22, 2022 06:48

harikrishna-patnala changed the base branch from main to 4.17 June 22, 2022 07:14

boring-cyborg Bot added component:agent component:build component:database component:orchestration distro:ubuntu labels Jun 22, 2022

Fix VMware VM migration with volume in case of local storage

50ca91a

harikrishna-patnala force-pushed the VMwareVMMigrationWithVolumeInLocalStorage branch from a1cbe0f to 50ca91a Compare June 22, 2022 07:20

harikrishna-patnala added this to the 4.17.1.0 milestone Jun 22, 2022

shwstppr reviewed Jun 22, 2022

View reviewed changes

Break the loop once target host is found

8c53536

shwstppr approved these changes Jun 22, 2022

View reviewed changes

sureshanaparti approved these changes Jun 27, 2022

View reviewed changes

Fixed code smells and added unit test

e87fd13

sureshanaparti reviewed Jun 28, 2022

View reviewed changes

Comment thread plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/guru/VMwareGuru.java

few variable changes

2f1702f

Added a comment

5b7b05e

DaanHoogland approved these changes Jun 28, 2022

View reviewed changes

DaanHoogland reviewed Jun 28, 2022

View reviewed changes

sureshanaparti merged commit 637a102 into 4.17 Jul 1, 2022

yadvr mentioned this pull request Jul 1, 2022

Unable to find the target datastore in datacenter -ACS with VMware #6270

Closed

DaanHoogland deleted the VMwareVMMigrationWithVolumeInLocalStorage branch March 14, 2023 14:54

Conversation

harikrishna-patnala commented Jun 22, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

Uh oh!

acs-robot commented Jun 22, 2022

Uh oh!

blueorangutan commented Jun 22, 2022

Uh oh!

blueorangutan commented Jun 22, 2022

Uh oh!

yadvr commented Jun 22, 2022

Uh oh!

blueorangutan commented Jun 22, 2022

Uh oh!

blueorangutan commented Jun 22, 2022

Uh oh!

harikrishna-patnala commented Jun 22, 2022

Uh oh!

shwstppr left a comment

Choose a reason for hiding this comment

Uh oh!

shwstppr Jun 22, 2022

Choose a reason for hiding this comment

Uh oh!

harikrishna-patnala Jun 22, 2022

Choose a reason for hiding this comment

Uh oh!

shwstppr commented Jun 22, 2022

Uh oh!

blueorangutan commented Jun 22, 2022

Uh oh!

blueorangutan commented Jun 22, 2022

Uh oh!

blueorangutan commented Jun 22, 2022

Uh oh!

blueorangutan commented Jun 22, 2022

Uh oh!

harikrishna-patnala commented Jun 27, 2022

Uh oh!

acs-robot commented Jun 27, 2022

Uh oh!

blueorangutan commented Jun 27, 2022

Uh oh!

blueorangutan commented Jun 27, 2022

Uh oh!

sureshanaparti left a comment

Choose a reason for hiding this comment

Uh oh!

DaanHoogland commented Jun 27, 2022

Uh oh!

acs-robot commented Jun 28, 2022

Uh oh!

blueorangutan commented Jun 28, 2022

Uh oh!

blueorangutan commented Jun 28, 2022

Uh oh!

Uh oh!

acs-robot commented Jun 28, 2022

Uh oh!

acs-robot commented Jun 28, 2022

Uh oh!

blueorangutan commented Jun 28, 2022

Uh oh!

blueorangutan commented Jun 28, 2022

Uh oh!

sureshanaparti commented Jun 28, 2022

Uh oh!

blueorangutan commented Jun 28, 2022

Uh oh!

blueorangutan commented Jun 28, 2022

Uh oh!

sonarqubecloud Bot commented Jun 28, 2022

Uh oh!

harikrishna-patnala commented Jun 22, 2022 •

edited

Loading