Volume encryption support for StorPool plug-in

[slavkap]

Description

Support of volume encryption for the StorPool plugin

Supported Virtual machine operations:

• live migration of VM to another host
• virtual machine snapshots (group snapshots without memory)
• revert VM snapshot
• delete VM snapshot

Supported Volume operations:

• attach/detach volume
• live migrate volume between two StorPool primary storages
• volume snapshot
• delete snapshot
• revert snapshot

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

How Has This Been Tested?

Environment:
CS mgmt - Rocky Linux
2 KVM hypervisors - Rocky

Smoke and manual tests

[codecov]

Codecov Report

Merging #7539 (2bc8fca) into 4.18 (22871ad) will increase coverage by 12.93%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##             4.18    #7539       +/-   ##
===========================================
+ Coverage        0   12.93%   +12.93%     
- Complexity      0     8948     +8948     
===========================================
  Files           0     2719     +2719     
  Lines           0   256290   +256290     
  Branches        0    39964    +39964     
===========================================
+ Hits            0    33139    +33139     
- Misses          0   218991   +218991     
- Partials        0     4160     +4160     

Impacted Files	Coverage Δ
.../src/main/java/com/cloud/host/dao/HostDaoImpl.java	27.85% <0.00%> (ø)
...api/storage/StorPoolSetVolumeEncryptionAnswer.java	0.00% <0.00%> (ø)
...pi/storage/StorPoolSetVolumeEncryptionCommand.java	0.00% <0.00%> (ø)
...per/StorPoolSetVolumeEncryptionCommandWrapper.java	0.00% <0.00%> (ø)
...tastore/driver/StorPoolPrimaryDataStoreDriver.java	0.00% <0.00%> (ø)
...ack/storage/motion/StorPoolDataMotionStrategy.java	0.00% <0.00%> (ø)
...n/java/com/cloud/storage/VolumeApiServiceImpl.java	14.65% <0.00%> (ø)

... and 2712 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[weizhouapache]

@blueorangutan package

[weizhouapache]

@slavkap
the code not related to storpool looks goood to me.

[DaanHoogland]

@blueorangutan package

[blueorangutan]

@DaanHoogland a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 6318

[DaanHoogland]

CLGTM

[DaanHoogland]

@blueorangutan test

[blueorangutan]

@DaanHoogland a [SF] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-6829)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 45811 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7539-t6829-kvm-centos7.zip
Smoke tests completed. 107 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_migrate_VM_and_root_volume	Error	85.93	test_vm_life_cycle.py
test_02_migrate_VM_with_two_data_disks	Error	57.51	test_vm_life_cycle.py

[weizhouapache]

code lgtm