Skip to content

ui: fix vm import for L2 n/w in Setup state - #7628

Merged
yadvr merged 1 commit into
apache:4.18from
shapeblue:fix-importvm-setupl2nw
Jun 27, 2023
Merged

yadvr merged 1 commit into
apache:4.18from
shapeblue:fix-importvm-setupl2nw

Conversation

@shwstppr

@shwstppr shwstppr commented Jun 14, 2023 •

Copy link
Copy Markdown
Contributor

Description

Fixes #7578
L2 networks created using offerings that allow using custom VLAN can remain in Setup state. Allow importing of VMs with such networks when VLAN matches with unmanaged instances.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Using UI

Network:
Screenshot from 2023-06-14 13-58-49

Before fix:

Screenshot from 2023-06-14 13-58-29

After fix:
Screenshot from 2023-06-14 13-58-03

L2 networks created using offerings that allow using custom VLAN can remain in Setup state. Allow importing of VMs with such networks when VLAN matches with unmanaged instance.

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@codecov

codecov Bot commented Jun 14, 2023

Copy link
Copy Markdown

Codecov Report

Merging #7628 (8fac917) into 4.18 (03910c2) will increase coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               4.18    #7628   +/-   ##
=========================================
  Coverage     12.98%   12.98%           
- Complexity     8984     8988    +4     
=========================================
  Files          2716     2716           
  Lines        256329   256340   +11     
  Branches      39974    39980    +6     
=========================================
+ Hits          33275    33289   +14     
+ Misses       218892   218886    -6     
- Partials       4162     4165    +3     

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@blueorangutan

Copy link
Copy Markdown

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 6229

@yadvr yadvr added this to the 4.18.1.0 milestone Jun 15, 2023

@DaanHoogland DaanHoogland left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@DaanHoogland

Copy link
Copy Markdown
Contributor

@blueorangutan ui

@blueorangutan

Copy link
Copy Markdown

@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/7628 (QA-JID-122)

@DaanHoogland

Copy link
Copy Markdown
Contributor

Is there an issue for this @shwstppr ? can you explain the scenario a bit more?

@shwstppr shwstppr linked an issue Jun 15, 2023 that may be closed by this pull request
@shwstppr

Copy link
Copy Markdown
Contributor Author

@DaanHoogland linked #7578

@yadvr
yadvr merged commit 83dca2b into apache:4.18 Jun 27, 2023
@yadvr
yadvr deleted the fix-importvm-setupl2nw branch June 27, 2023 09:27
@okodhe2

okodhe2 commented Feb 19, 2025 •

Copy link
Copy Markdown

ACS_L2
How is this fixed applied? Am experiencing similar issue with a newly updated ACS 4.20.0.0

@shwstppr

Copy link
Copy Markdown
Contributor Author

@okodhe2 this is already present in 4.20.
From your screenshot it seems vlan for the nic is being retrieved as 0. Can you check why is that? Maybe open a new discussion if needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Import Unamanged VM fails due to no matching network found

6 participants