Skip to content

agent: remove powermock from tests - #7637

Merged
weizhouapache merged 1 commit into
apache:mainfrom
shapeblue:agent-remove-powermock
Jun 20, 2023
Merged

weizhouapache merged 1 commit into
apache:mainfrom
shapeblue:agent-remove-powermock

Conversation

@vishesh92

@vishesh92 vishesh92 commented Jun 15, 2023

Copy link
Copy Markdown
Member

Description

This PR removes usage of powermock from agent's tests.

After this change, this is the remaining usage of powermock left.

$ git grep "PowerMockito" | tr "/" " "| awk '{print $1, $2, $3, $4}' | sort | uniq -c 
     76 api src test java
     51 core src test java
     37 engine schema src test
     68 engine storage configdrive src
      9 engine storage snapshot src
     11 plugins acl project-role-based src
      3 plugins database quota src
    150 plugins hypervisors kvm src
      3 plugins hypervisors vmware src
     40 plugins hypervisors xenserver src
      5 plugins integrations kubernetes-service src
      2 plugins network-elements nicira-nvp src
     96 plugins network-elements tungsten src
      1 plugins storage volume storpool
     17 plugins user-authenticators ldap src
    196 server src test java
      4 services console-proxy server src
      2 services secondary-storage server src
      2 vmware-base src test java

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

@codecov

codecov Bot commented Jun 15, 2023

Copy link
Copy Markdown

Codecov Report

Merging #7637 (c59208f) into main (27b0a64) will increase coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #7637   +/-   ##
=========================================
  Coverage     13.12%   13.13%           
- Complexity     9143     9147    +4     
=========================================
  Files          2728     2728           
  Lines        256997   256997           
  Branches      40067    40067           
=========================================
+ Hits          33729    33748   +19     
+ Misses       219021   218997   -24     
- Partials       4247     4252    +5     

see 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@vishesh92

Copy link
Copy Markdown
Member Author

@blueorangutan package

@blueorangutan

Copy link
Copy Markdown

@vishesh92 a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@vishesh92
vishesh92 marked this pull request as ready for review June 15, 2023 19:08
@blueorangutan

Copy link
Copy Markdown

Packaging result [SF]: ✖️ el7 ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 6242

@vishesh92

Copy link
Copy Markdown
Member Author

@blueorangutan package

@blueorangutan

Copy link
Copy Markdown

@vishesh92 a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

Packaging result [SF]: ✖️ el7 ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 6245

@vishesh92 vishesh92 closed this Jun 16, 2023
@vishesh92 vishesh92 reopened this Jun 16, 2023
@vishesh92
vishesh92 marked this pull request as draft June 16, 2023 05:41
@vishesh92
vishesh92 force-pushed the agent-remove-powermock branch from 46aa4da to c59208f Compare June 18, 2023 07:32
@vishesh92

Copy link
Copy Markdown
Member Author

@blueorangutan package

@blueorangutan

Copy link
Copy Markdown

@vishesh92 a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 6257

@vishesh92
vishesh92 marked this pull request as ready for review June 18, 2023 08:29
@yadvr

yadvr commented Jun 18, 2023

Copy link
Copy Markdown
Member

@blueorangutan test

@blueorangutan

Copy link
Copy Markdown

@rohityadavcloud a [SF] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan

Copy link
Copy Markdown

[SF] Trillian test result (tid-6757)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 39217 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7637-t6757-kvm-centos7.zip
Smoke tests completed. 111 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File

@DaanHoogland DaanHoogland left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tlgtm

@weizhouapache

Copy link
Copy Markdown
Member

code lgtm

@vishesh92
are you still working on other tests ? will you update this PR or create new PR ?

@vishesh92

Copy link
Copy Markdown
Member Author

@weizhouapache I was planning to create separate PRs. Not sure how much time it will take to replace all the tests. And I don't want to have one huge PR with a lot of changes.

@weizhouapache

Copy link
Copy Markdown
Member

@weizhouapache I was planning to create separate PRs. Not sure how much time it will take to replace all the tests. And I don't want to have one huge PR with a lot of changes.

@vishesh92
fine, I will merge this

@weizhouapache
weizhouapache merged commit e26d49d into apache:main Jun 20, 2023
@DaanHoogland DaanHoogland added this to the 4.19.0.0 milestone Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants