Fix storpool test & remove powermock

[vishesh92]

Description

This PR fixes unit tests for plugins/storage/volume/storpool/ and removes powermock.

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

[codecov]

Codecov Report

Merging #7652 (6128822) into main (27b0a64) will increase coverage by 0.04%.
The diff coverage is 50.00%.

@@             Coverage Diff              @@
##               main    #7652      +/-   ##
============================================
+ Coverage     13.12%   13.16%   +0.04%     
- Complexity     9143     9166      +23     
============================================
  Files          2728     2728              
  Lines        256997   257000       +3     
  Branches      40067    40068       +1     
============================================
+ Hits          33729    33844     +115     
+ Misses       219021   218887     -134     
- Partials       4247     4269      +22     

Impacted Files	Coverage Δ
...loudstack/storage/datastore/util/StorPoolUtil.java	8.38% <50.00%> (+8.38%)	⬆️

... and 6 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[vishesh92]

@blueorangutan package

[blueorangutan]

@vishesh92 a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 6270

[vishesh92]

@blueorangutan test

[blueorangutan]

@vishesh92 a [SF] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-6770)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 40479 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7652-t6770-kvm-centos7.zip
Smoke tests completed. 111 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

[vishesh92]

@slavkap Can you review this?

One minor change in StorPoolUtil.java which checks if /var/log/cloudstack/management/ directory exists or not and depending on that selects the path of the log file. Tests were failing if /var/log/cloudstack/management/ was not present on the filesystem.

[DaanHoogland]

clgtm

[slavkap]

Thanks, @vishesh92, the code LGTM

[DaanHoogland]

@slavkap Do you need to test this, as StorePoolUtil cahnged?

[yadvr]

Merging based on @slavkap 's and others review, build and smoketests.