engine-orchestration: fix volume size resource count mismatch

[shwstppr]

Description

Fixes case of account/domain having negative storage count when there is a volume size difference while deploying volumes on certain stroages. In case of Powerflex volume size results in a multiple of 8. If user deploys a volume of 12GB it will result in 16GB in size. But currently CloudStack will not update resource count after deployment.

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

[codecov]

Codecov Report

Merging #7666 (0044058) into 4.18 (1aa4f80) will increase coverage by 0.03%.
The diff coverage is 84.61%.

@@             Coverage Diff              @@
##               4.18    #7666      +/-   ##
============================================
+ Coverage     12.98%   13.02%   +0.03%     
- Complexity     8989     9017      +28     
============================================
  Files          2716     2716              
  Lines        256343   256668     +325     
  Branches      39981    40023      +42     
============================================
+ Hits          33291    33432     +141     
- Misses       218886   219050     +164     
- Partials       4166     4186      +20     

Impacted Files	Coverage Δ
...stack/engine/orchestration/VolumeOrchestrator.java	1.91% <84.61%> (+1.91%)	⬆️

... and 14 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[shwstppr]

@blueorangutan package

[blueorangutan]

@shwstppr a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 6300

[shwstppr]

@blueorangutan test

[blueorangutan]

@shwstppr a [SF] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-6803)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 48170 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7666-t6803-kvm-centos7.zip
Smoke tests completed. 106 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_02_list_cpvm_vm	Failure	0.03	test_ssvm.py
test_04_cpvm_internals	Failure	0.06	test_ssvm.py
test_01_migrate_VM_and_root_volume	Error	76.71	test_vm_life_cycle.py
test_02_migrate_VM_with_two_data_disks	Error	52.40	test_vm_life_cycle.py

[yadvr]

Code LGTM didn't test it though

[blueorangutan]

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 6360

[borisstoyanov]

Managed to reproduce with nightly packages for 4.18:

Then upgraded to this PR and got the expected behaviour:

LGTM

[yadvr]

@blueorangutan test

[blueorangutan]

@rohityadavcloud a [SF] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-6901)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 52002 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7666-t6901-kvm-centos7.zip
Smoke tests completed. 106 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_08_upgrade_kubernetes_ha_cluster	Failure	1040.23	test_kubernetes_clusters.py
test_01_migrate_VM_and_root_volume	Error	78.77	test_vm_life_cycle.py
test_02_migrate_VM_with_two_data_disks	Error	55.46	test_vm_life_cycle.py

[yadvr]

Intermittent failures same as in #7345 merging this