Skip to content

scaleio: fix build error after 4.18 merge forward - #7669

Merged
weizhouapache merged 1 commit into
mainfrom
4.19-fix-scaleio-tests
Jun 21, 2023
Merged

weizhouapache merged 1 commit into
mainfrom
4.19-fix-scaleio-tests

Conversation

@weizhouapache

Copy link
Copy Markdown
Member

Description

This PR...

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

@weizhouapache

Copy link
Copy Markdown
Member Author

@blueorangutan package

@blueorangutan

Copy link
Copy Markdown

@weizhouapache a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✖️ debian ✔️ suse15. SL-JID 6299

@codecov

codecov Bot commented Jun 21, 2023

Copy link
Copy Markdown

Codecov Report

Merging #7669 (ea05f1c) into main (071a071) will increase coverage by 0.09%.
The diff coverage is 61.64%.

@@             Coverage Diff              @@
##               main    #7669      +/-   ##
============================================
+ Coverage     13.13%   13.22%   +0.09%     
- Complexity     9147     9201      +54     
============================================
  Files          2728     2728              
  Lines        256997   257324     +327     
  Branches      40067    40114      +47     
============================================
+ Hits          33748    34028     +280     
- Misses       218997   219007      +10     
- Partials       4252     4289      +37     
Impacted Files Coverage Δ
.../main/java/com/cloud/vm/VirtualMachineManager.java 92.30% <ø> (ø)
...e/cloudstack/storage/volume/VolumeServiceImpl.java 2.27% <0.00%> (-0.01%) ⬇️
...oud/hypervisor/kvm/resource/LibvirtConnection.java 0.00% <0.00%> (ø)
...ud/hypervisor/kvm/storage/KVMStorageProcessor.java 4.97% <0.00%> (-0.02%) ⬇️
.../hypervisor/kvm/storage/ScaleIOStorageAdaptor.java 10.44% <0.00%> (-0.04%) ⬇️
...ain/java/com/cloud/hypervisor/guru/VMwareGuru.java 1.06% <0.00%> (ø)
...age/datastore/client/ScaleIOGatewayClientImpl.java 22.16% <0.00%> (ø)
...rvisor/kvm/discoverer/LibvirtServerDiscoverer.java 0.00% <0.00%> (ø)
...n/java/com/cloud/storage/VolumeApiServiceImpl.java 15.05% <0.00%> (+0.02%) ⬆️
.../src/main/java/com/cloud/vm/UserVmManagerImpl.java 7.35% <ø> (+<0.01%) ⬆️
... and 5 more

... and 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@weizhouapache

Copy link
Copy Markdown
Member Author

rpm packaging jobs succeeded (the debian packaging are not related), merging

@weizhouapache
weizhouapache merged commit 5347d06 into main Jun 21, 2023
@weizhouapache
weizhouapache deleted the 4.19-fix-scaleio-tests branch June 21, 2023 18:24
@DaanHoogland DaanHoogland added this to the 4.19.0.0 milestone Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants