If ResourceCountCheckTask throws an exception the scheduled task is not going to run again until the management servers are restarted.

[mprokopchuk]

Added try/catch to log the issue, continue processing of the next resources and running again according to the schedule.

Description

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Tested manually

[shwstppr]

LGTM

[shwstppr]

@blueorangutan package

[blueorangutan]

@shwstppr a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[codecov]

Codecov Report

Merging #7670 (b290444) into main (5347d06) will increase coverage by 0.08%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##               main    #7670      +/-   ##
============================================
+ Coverage     13.21%   13.30%   +0.08%     
- Complexity     9198     9260      +62     
============================================
  Files          2728     2735       +7     
  Lines        257324   257843     +519     
  Branches      40114    40167      +53     
============================================
+ Hits          34016    34313     +297     
- Misses       219023   219200     +177     
- Partials       4285     4330      +45     

Impacted Files	Coverage Δ
.../cloud/resourcelimit/ResourceLimitManagerImpl.java	1.03% <0.00%> (-0.04%)	⬇️

... and 13 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[blueorangutan]

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 6319

[mprokopchuk]

@DaanHoogland renamed methods to recalculateAccountResourceCountInContext and recalculateDomainResourceCountInContext

[mlsorensen]

@blueorangutan package

[blueorangutan]

@mlsorensen a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 6363

[mlsorensen]

Let's try again...

@blueorangutan test

[blueorangutan]

@mlsorensen a [SF] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-6924)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 41624 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7670-t6924-kvm-centos7.zip
Smoke tests completed. 112 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_migrate_VM_and_root_volume	Error	79.83	test_vm_life_cycle.py
test_02_migrate_VM_with_two_data_disks	Error	53.44	test_vm_life_cycle.py

[DaanHoogland]

clgtm

[mlsorensen]

Errors look unrelated to this code change, they're at the KVM hypervisor layer (maybe due to an earlier commit, seems the live volume migration feature is unsupported in whatever host):

org.libvirt.LibvirtException: internal error: unable to execute QEMU command \\\'migrate\\\': this feature or command is not currently supported

lgtm