[cleanup] Deleted file FakeDhcpSnooper.java and DhcpSnooper.java by nikam14 · Pull Request #7672 · apache/cloudstack

nikam14 · 2023-06-22T07:21:03Z

Description

This PR... fixes #7646

the class FakeDhcpSnooper.java and the class DhcpSnooper.java haven't been used anywhere in the code. They were added in 2011 for testing but they are no longer used.

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

DaanHoogland · 2023-06-22T07:58:36Z

@blueorangutan package

blueorangutan · 2023-06-22T08:00:03Z

@DaanHoogland a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2023-06-22T08:55:04Z

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 6310

codecov · 2023-06-22T08:57:14Z

Codecov Report

Merging #7672 (2e67961) into main (b635ecb) will increase coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #7672   +/-   ##
=========================================
  Coverage     13.21%   13.22%           
- Complexity     9197     9200    +3     
=========================================
  Files          2728     2728           
  Lines        257324   257324           
  Branches      40114    40114           
=========================================
+ Hits          34013    34026   +13     
+ Misses       219026   219008   -18     
- Partials       4285     4290    +5

see 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

DaanHoogland · 2023-06-22T16:01:46Z

@blueorangutan test matrix

blueorangutan · 2023-06-22T16:02:03Z

@DaanHoogland a [SF] Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests

blueorangutan · 2023-06-22T23:49:50Z

[SF] Trillian test result (tid-6818)
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8
Total time taken: 26570 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7672-t6818-vmware-67u3.zip
Smoke tests completed. 86 look OK, 0 have errors, 25 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
all_test_safe_shutdown	`Skipped`	---	test_safe_shutdown.py
all_test_metrics_api	`Skipped`	---	test_metrics_api.py
all_test_outofbandmanagement	`Skipped`	---	test_outofbandmanagement.py
all_test_outofbandmanagement_nestedplugin	`Skipped`	---	test_outofbandmanagement_nestedplugin.py
all_test_routers_iptables_default_policy	`Skipped`	---	test_routers_iptables_default_policy.py
all_test_secondary_storage	`Skipped`	---	test_secondary_storage.py
all_test_service_offerings	`Skipped`	---	test_service_offerings.py
all_test_staticroles	`Skipped`	---	test_staticroles.py
all_test_storage_policy	`Skipped`	---	test_storage_policy.py
all_test_templates	`Skipped`	---	test_templates.py
all_test_update_security_group	`Skipped`	---	test_update_security_group.py
all_test_usage_events	`Skipped`	---	test_usage_events.py
all_test_vm_autoscaling	`Skipped`	---	test_vm_autoscaling.py
all_test_vm_deployment_planner	`Skipped`	---	test_vm_deployment_planner.py
all_test_vm_life_cycle	`Skipped`	---	test_vm_life_cycle.py
all_test_vm_snapshot_kvm	`Skipped`	---	test_vm_snapshot_kvm.py
all_test_vm_lifecycle_unmanage_import	`Skipped`	---	test_vm_lifecycle_unmanage_import.py
all_test_vm_snapshots	`Skipped`	---	test_vm_snapshots.py
all_test_volumes	`Skipped`	---	test_volumes.py
all_test_vpc_ipv6	`Skipped`	---	test_vpc_ipv6.py
all_test_vpc_redundant	`Skipped`	---	test_vpc_redundant.py
all_test_vpc_router_nics	`Skipped`	---	test_vpc_router_nics.py
all_test_vpc_vpn	`Skipped`	---	test_vpc_vpn.py
all_test_host_maintenance	`Skipped`	---	test_host_maintenance.py
all_test_hostha_kvm	`Skipped`	---	test_hostha_kvm.py

blueorangutan · 2023-06-23T03:44:46Z

[SF] Trillian test result (tid-6817)
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 40666 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7672-t6817-xenserver-71.zip
Smoke tests completed. 110 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_11_destroy_ssvm	`Error`	6.24	test_ssvm.py

blueorangutan · 2023-06-23T04:07:34Z

[SF] Trillian test result (tid-6819)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 41914 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7672-t6819-kvm-centos7.zip
Smoke tests completed. 110 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_migrate_VM_and_root_volume	`Error`	82.93	test_vm_life_cycle.py
test_02_migrate_VM_with_two_data_disks	`Error`	53.52	test_vm_life_cycle.py

DaanHoogland · 2023-06-23T10:25:50Z

@blueorangutan test rocky8 vmware-67u3

blueorangutan · 2023-06-23T10:26:03Z

@DaanHoogland a [SF] Trillian-Jenkins test job (rocky8 mgmt + vmware-67u3) has been kicked to run smoke tests

soreana

LGTM

blueorangutan · 2023-06-24T02:33:17Z

[SF] Trillian test result (tid-6826)
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8
Total time taken: 56477 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7672-t6826-vmware-67u3.zip
Smoke tests completed. 108 look OK, 3 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_attach_and_distribute_multiple_volumes	`Failure`	52.04	test_attach_multiple_volumes.py
test_01_deploy_vm_on_specific_host	`Error`	16.68	test_vm_deployment_planner.py
test_02_deploy_vm_on_specific_cluster	`Error`	3605.55	test_vm_deployment_planner.py
test_03_deploy_vm_on_specific_pod	`Error`	1.35	test_vm_deployment_planner.py
test_04_deploy_vm_on_host_override_pod_and_cluster	`Error`	2.37	test_vm_deployment_planner.py
test_05_deploy_vm_on_cluster_override_pod	`Error`	1.31	test_vm_deployment_planner.py
test_09_expunge_vm	`Failure`	424.67	test_vm_life_cycle.py

blueorangutan · 2023-06-26T23:39:13Z

[SF] Trillian test result (tid-6856)
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8
Total time taken: 55453 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7672-t6856-vmware-67u3.zip
Smoke tests completed. 109 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_deploy_vm_on_specific_host	`Error`	17.81	test_vm_deployment_planner.py
test_02_deploy_vm_on_specific_cluster	`Error`	3602.65	test_vm_deployment_planner.py
test_03_deploy_vm_on_specific_pod	`Error`	2.32	test_vm_deployment_planner.py
test_04_deploy_vm_on_host_override_pod_and_cluster	`Error`	1.28	test_vm_deployment_planner.py
test_05_deploy_vm_on_cluster_override_pod	`Error`	2.29	test_vm_deployment_planner.py
test_09_expunge_vm	`Failure`	424.76	test_vm_life_cycle.py

DaanHoogland

clgtm

shwstppr · 2023-10-09T08:12:52Z

@blueorangutan package

blueorangutan · 2023-10-09T08:14:04Z

@shwstppr a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2023-10-09T09:25:28Z

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 7269

weizhouapache

code lgtm

DaanHoogland · 2023-10-09T10:23:19Z

@blueorangutan test matrix

blueorangutan · 2023-10-09T10:24:03Z

@DaanHoogland a [SF] Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests

blueorangutan · 2023-10-10T00:07:39Z

[SF] Trillian test result (tid-7878)
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 47978 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7672-t7878-xenserver-71.zip
Smoke tests completed. 113 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

blueorangutan · 2023-10-10T01:14:56Z

[SF] Trillian test result (tid-7880)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 51895 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7672-t7880-kvm-centos7.zip
Smoke tests completed. 112 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_08_upgrade_kubernetes_ha_cluster	`Failure`	3668.02	test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster	`Failure`	0.07	test_kubernetes_clusters.py
ContextSuite context=TestKubernetesCluster>:teardown	`Error`	103.21	test_kubernetes_clusters.py

blueorangutan · 2023-10-10T08:33:16Z

[SF] Trillian test result (tid-7879)
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8
Total time taken: 78255 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7672-t7879-vmware-67u3.zip
Smoke tests completed. 111 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_list_system_vms_metrics_history	`Failure`	0.28	test_metrics_api.py
test_list_vms_metrics_admin	`Error`	3611.58	test_metrics_api.py
test_list_vms_metrics_history	`Error`	3607.67	test_metrics_api.py
test_list_volumes_metrics_history	`Error`	3624.05	test_metrics_api.py
test_01_deploy_vm_on_specific_host	`Error`	4.43	test_vm_deployment_planner.py
test_02_deploy_vm_on_specific_cluster	`Error`	1.29	test_vm_deployment_planner.py
test_03_deploy_vm_on_specific_pod	`Error`	12.63	test_vm_deployment_planner.py
test_04_deploy_vm_on_host_override_pod_and_cluster	`Error`	3602.29	test_vm_deployment_planner.py
test_05_deploy_vm_on_cluster_override_pod	`Error`	4.40	test_vm_deployment_planner.py

nikam14 added 2 commits June 22, 2023 12:44

Delete DhcpSnooper.java

a5ff386

Delete FakeDhcpSnooper.java

2e67961

boring-cyborg Bot added the component:agent label Jun 22, 2023

weizhouapache changed the title ~~[fixes #7646][Enhancement] Deleted file FakeDhcpSnooper.java and DhcpSnooper.java~~ [cleanup] Deleted file FakeDhcpSnooper.java and DhcpSnooper.java Jun 22, 2023

DaanHoogland added this to the 4.19.0.0 milestone Jun 22, 2023

weizhouapache removed the component:agent label Jun 22, 2023

soreana approved these changes Jun 23, 2023

View reviewed changes

DaanHoogland approved these changes Jul 3, 2023

View reviewed changes

weizhouapache approved these changes Oct 9, 2023

View reviewed changes

weizhouapache merged commit b58ffec into apache:main Oct 10, 2023

Conversation

nikam14 commented Jun 22, 2023

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Uh oh!

DaanHoogland commented Jun 22, 2023

Uh oh!

blueorangutan commented Jun 22, 2023

Uh oh!

blueorangutan commented Jun 22, 2023

Uh oh!

codecov Bot commented Jun 22, 2023

Codecov Report

Uh oh!

DaanHoogland commented Jun 22, 2023

Uh oh!

blueorangutan commented Jun 22, 2023

Uh oh!

blueorangutan commented Jun 22, 2023

Uh oh!

blueorangutan commented Jun 23, 2023

Uh oh!

blueorangutan commented Jun 23, 2023

Uh oh!

DaanHoogland commented Jun 23, 2023

Uh oh!

blueorangutan commented Jun 23, 2023

Uh oh!

soreana left a comment

Choose a reason for hiding this comment

Uh oh!

blueorangutan commented Jun 24, 2023

Uh oh!

blueorangutan commented Jun 26, 2023

Uh oh!

DaanHoogland left a comment

Choose a reason for hiding this comment

Uh oh!

shwstppr commented Oct 9, 2023

Uh oh!

blueorangutan commented Oct 9, 2023

Uh oh!

blueorangutan commented Oct 9, 2023

Uh oh!

weizhouapache left a comment

Choose a reason for hiding this comment

Uh oh!

DaanHoogland commented Oct 9, 2023

Uh oh!

blueorangutan commented Oct 9, 2023

Uh oh!

blueorangutan commented Oct 10, 2023

Uh oh!

blueorangutan commented Oct 10, 2023

Uh oh!

blueorangutan commented Oct 10, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants