Skip to content

api: correct error on resize volume resource allocation failure - #7687

Merged
yadvr merged 2 commits into
apache:4.18from
shapeblue:fix-418-resizevol-exceptionerrcode
Jul 3, 2023
Merged

yadvr merged 2 commits into
apache:4.18from
shapeblue:fix-418-resizevol-exceptionerrcode

Conversation

@shwstppr

Copy link
Copy Markdown
Contributor

Description

This PR resource throws exception with the correct error code and logs the error message when a resource allocation failure is encountered during resize volume operation.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

This PR resource throws exception with correct error code and logs the erro message when a resource allocation failure is encountered during resize volume operation.

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@shwstppr

Copy link
Copy Markdown
Contributor Author

@blueorangutan package

@blueorangutan

Copy link
Copy Markdown

@shwstppr a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@weizhouapache weizhouapache left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

@blueorangutan

Copy link
Copy Markdown

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 6334

@shwstppr

Copy link
Copy Markdown
Contributor Author

@blueorangutan test

@blueorangutan

Copy link
Copy Markdown

@shwstppr a [SF] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@codecov

codecov Bot commented Jun 26, 2023 •

Copy link
Copy Markdown

Codecov Report

Merging #7687 (61dabcb) into 4.18 (c809201) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##               4.18    #7687      +/-   ##
============================================
- Coverage     13.01%   13.00%   -0.01%     
  Complexity     9013     9013              
============================================
  Files          2716     2719       +3     
  Lines        256690   256854     +164     
  Branches      40026    40048      +22     
============================================
  Hits          33413    33413              
- Misses       219091   219255     +164     
  Partials       4186     4186              
Impacted Files Coverage Δ
...main/java/com/cloud/api/ApiAsyncJobDispatcher.java 0.00% <0.00%> (ø)

... and 7 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@DaanHoogland DaanHoogland left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@blueorangutan

Copy link
Copy Markdown

[SF] Trillian test result (tid-6855)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 45724 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7687-t6855-kvm-centos7.zip
Smoke tests completed. 106 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_01_migrate_VM_and_root_volume Error 76.57 test_vm_life_cycle.py
test_02_migrate_VM_with_two_data_disks Error 52.38 test_vm_life_cycle.py
test_02_unsecure_vm_migration Error 226.16 test_vm_life_cycle.py
test_03_secured_to_nonsecured_vm_migration Error 145.05 test_vm_life_cycle.py
test_04_nonsecured_to_secured_vm_migration Error 139.90 test_vm_life_cycle.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL Failure 1018.08 test_vpc_redundant.py

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@shwstppr

Copy link
Copy Markdown
Contributor Author

@blueorangutan package

@blueorangutan

Copy link
Copy Markdown

@shwstppr a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 6345

@borisstoyanov

Copy link
Copy Markdown
Contributor

@blueorangutan test

@borisstoyanov borisstoyanov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, manually tested

@shwstppr
shwstppr marked this pull request as ready for review June 27, 2023 07:42
@yadvr yadvr added this to the 4.18.1.0 milestone Jun 27, 2023
@apache apache deleted a comment from blueorangutan Jun 28, 2023
@apache apache deleted a comment from blueorangutan Jun 29, 2023
@apache apache deleted a comment from blueorangutan Jun 29, 2023
@apache apache deleted a comment from blueorangutan Jun 29, 2023
@yadvr

yadvr commented Jun 29, 2023

Copy link
Copy Markdown
Member

@blueorangutan test

@blueorangutan

Copy link
Copy Markdown

@rohityadavcloud a [SF] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan

Copy link
Copy Markdown

[SF] Trillian test result (tid-6902)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 44864 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7687-t6902-kvm-centos7.zip
Smoke tests completed. 106 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_01_migrate_VM_and_root_volume Error 76.70 test_vm_life_cycle.py
test_02_migrate_VM_with_two_data_disks Error 54.50 test_vm_life_cycle.py
test_04_nonsecured_to_secured_vm_migration Error 151.21 test_vm_life_cycle.py
test_04_rvpc_network_garbage_collector_nics Failure 376.02 test_vpc_redundant.py

@yadvr

yadvr commented Jul 3, 2023

Copy link
Copy Markdown
Member

Intermittent errors same as in the 4.18/baseline #7345 merging this based on this.

@yadvr
yadvr merged commit de6ce50 into apache:4.18 Jul 3, 2023
@yadvr
yadvr deleted the fix-418-resizevol-exceptionerrcode branch July 3, 2023 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants