use Files.createTempDirectory() instead of new File()

[DaanHoogland]

Description

This PR addresses a static analysis concern with temp file creation. It is not a security issue but an improvement nonetheless.

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

unit test added

[oscerd]

LGTM. Thanks.

[yadvr]

LGTM - need smoketests (I havent' tested it)

[yadvr]

@DaanHoogland should this be targeted to 4.18 branch as well?

[codecov]

Codecov Report

Merging #7713 (8a196b5) into 4.18 (31dbdd0) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               4.18    #7713      +/-   ##
============================================
- Coverage     13.02%   13.02%   -0.01%     
  Complexity     9022     9022              
============================================
  Files          2719     2719              
  Lines        256863   256872       +9     
  Branches      40049    40050       +1     
============================================
  Hits          33449    33449              
- Misses       219226   219235       +9     
  Partials       4188     4188              

see 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[DaanHoogland]

@blueorangutan package

[blueorangutan]

@DaanHoogland a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 6395

[harikrishna-patnala]

code LGTM

[DaanHoogland]

@blueorangutan test

[blueorangutan]

@DaanHoogland a [SF] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[yadvr]

LGTM - thanks Daan for changing base to 4.18

[blueorangutan]

[SF] Trillian test result (tid-6963)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 48124 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7713-t6963-kvm-centos7.zip
Smoke tests completed. 107 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_migrate_VM_and_root_volume	Error	81.66	test_vm_life_cycle.py
test_02_migrate_VM_with_two_data_disks	Error	53.34	test_vm_life_cycle.py

[DaanHoogland]

@blueorangutan package

[blueorangutan]

@DaanHoogland a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 6413

[DaanHoogland]

@blueorangutan test

[blueorangutan]

@DaanHoogland a [SF] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian Build Failed (tid-6990)

[blueorangutan]

[SF] Trillian test result (tid-6996)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 42792 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7713-t6996-kvm-centos7.zip
Smoke tests completed. 107 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_migrate_VM_and_root_volume	Error	79.79	test_vm_life_cycle.py
test_02_migrate_VM_with_two_data_disks	Error	54.47	test_vm_life_cycle.py