Fix lint errors - #7727
Fix lint errors#7727
Conversation
DaanHoogland
left a comment
There was a problem hiding this comment.
slipped through the maze. should have been cought before. thanks @vishesh92
|
I think only the gh actions should be enough on this one. |
Codecov Report
@@ Coverage Diff @@
## main #7727 +/- ##
============================================
- Coverage 13.39% 13.38% -0.02%
- Complexity 9347 9505 +158
============================================
Files 2743 2743
Lines 258553 263332 +4779
Branches 40281 42458 +2177
============================================
+ Hits 34646 35246 +600
- Misses 219533 223623 +4090
- Partials 4374 4463 +89
... and 13 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
I checked the build error in the unit test. Doesn't happen to me locally. Running smoke tests anyway. |
|
@blueorangutan package |
|
@DaanHoogland a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 6429 |
|
@blueorangutan test keepEnv |
|
@DaanHoogland a [SF] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests |
|
[SF] Trillian test result (tid-7011)
|
|
@vishesh92 do you want to wait with merging this till after #7732 has been merged (forward)? |
|
@DaanHoogland yes. Let's wait. |
|
About https://github.com/apache/cloudstack/actions/runs/5475638802/jobs/9972019731?pr=7727 manual running the source_nat tests passes: and for kubernetes_clusters: with no exception on tear down. |
Description
This PR fixes pre-commit hook's lint errors to fix
pre-commitgithub action.Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?