Skip to content

Fix lint errors - #7727

Merged
yadvr merged 1 commit into
apache:mainfrom
shapeblue:fix-lint-errors
Jul 7, 2023
Merged

yadvr merged 1 commit into
apache:mainfrom
shapeblue:fix-lint-errors

Conversation

@vishesh92

Copy link
Copy Markdown
Member

Description

This PR fixes pre-commit hook's lint errors to fix pre-commit github action.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

@weizhouapache weizhouapache left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

@DaanHoogland DaanHoogland left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

slipped through the maze. should have been cought before. thanks @vishesh92

@DaanHoogland

Copy link
Copy Markdown
Contributor

I think only the gh actions should be enough on this one.

@codecov

codecov Bot commented Jul 6, 2023

Copy link
Copy Markdown

Codecov Report

Merging #7727 (e51dd3d) into main (02be2cd) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #7727      +/-   ##
============================================
- Coverage     13.39%   13.38%   -0.02%     
- Complexity     9347     9505     +158     
============================================
  Files          2743     2743              
  Lines        258553   263332    +4779     
  Branches      40281    42458    +2177     
============================================
+ Hits          34646    35246     +600     
- Misses       219533   223623    +4090     
- Partials       4374     4463      +89     
Impacted Files Coverage Δ
...nbase/CitrixCheckGuestOsMappingCommandWrapper.java 10.00% <ø> (ø)
...CitrixGetHypervisorGuestOsNamesCommandWrapper.java 8.33% <ø> (ø)

... and 13 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@DaanHoogland

Copy link
Copy Markdown
Contributor

I checked the build error in the unit test. Doesn't happen to me locally. Running smoke tests anyway.

@DaanHoogland

DaanHoogland commented Jul 6, 2023

Copy link
Copy Markdown
Contributor

@blueorangutan package

@blueorangutan

Copy link
Copy Markdown

@DaanHoogland a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@DaanHoogland DaanHoogland reopened this Jul 6, 2023
@blueorangutan

Copy link
Copy Markdown

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 6429

@DaanHoogland

Copy link
Copy Markdown
Contributor

@blueorangutan test keepEnv

@blueorangutan

Copy link
Copy Markdown

@DaanHoogland a [SF] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan

Copy link
Copy Markdown

[SF] Trillian test result (tid-7011)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 42861 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7727-t7011-kvm-centos7.zip
Smoke tests completed. 111 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_01_migrate_VM_and_root_volume Error 77.75 test_vm_life_cycle.py
test_02_migrate_VM_with_two_data_disks Error 52.47 test_vm_life_cycle.py
test_05_vmschedule_test_e2e Failure 240.66 test_vm_schedule.py

@DaanHoogland

Copy link
Copy Markdown
Contributor

@vishesh92 do you want to wait with merging this till after #7732 has been merged (forward)?
cc @weizhouapache

@vishesh92

Copy link
Copy Markdown
Member Author

@DaanHoogland yes. Let's wait.

@DaanHoogland

Copy link
Copy Markdown
Contributor

About https://github.com/apache/cloudstack/actions/runs/5475638802/jobs/9972019731?pr=7727 manual running the source_nat tests passes:

...
=== TestName: test_03_create_vpc_with_specified_source_nat_ip_address | Status : SUCCESS ===

=== TestName: test_04_change_source_nat_ip_address_for_vpc | Status : SUCCESS ===
....

and for kubernetes_clusters:

=== TestName: test_11_test_unmanaged_cluster_lifecycle | Status : SUCCESS ===

with no exception on tear down.

@yadvr
yadvr merged commit d2cd3c8 into apache:main Jul 7, 2023
@yadvr yadvr added this to the 4.19.0.0 milestone Jul 7, 2023
@DaanHoogland
DaanHoogland deleted the fix-lint-errors branch July 20, 2023 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants