Set encrypted PowerFlex datadisk format correctly - #7729
Closed
mlsorensen wants to merge 1 commit into
Closed
mlsorensen wants to merge 1 commit into
mlsorensen wants to merge 1 commit into
Conversation
Codecov Report
@@ Coverage Diff @@
## main #7729 +/- ##
=========================================
Coverage 13.39% 13.39%
Complexity 9344 9344
=========================================
Files 2743 2743
Lines 258571 258571
Branches 40279 40279
=========================================
+ Hits 34630 34632 +2
- Misses 219569 219570 +1
+ Partials 4372 4369 -3
... and 4 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
harikrishna-patnala
approved these changes
Jul 7, 2023
harikrishna-patnala
left a comment
Member
There was a problem hiding this comment.
Code LGTM. It's better to test the volume operations since we are dealing with volume format here.
Member
|
@mlsorensen can we target this to 4.18.1 please, this needs to change the base branch. |
Contributor
Author
|
Closing in favor of #7735 - against 4.18 branch. I wasn't able to change the base branch away from main via edit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR:
This allows us to trigger the code that resizes the qcow2 container if we are thin provisioned - this wasn't working for data volumes when VM was stopped because they were hard coded to RAW format.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
Tested locally against powerflex, both detached and attached volume.