Skip to content

Set encrypted PowerFlex datadisk format correctly - #7729

Closed
mlsorensen wants to merge 1 commit into
apache:mainfrom
mlsorensen:main-resize-powerflex-thin-datavol
Closed

mlsorensen wants to merge 1 commit into
apache:mainfrom
mlsorensen:main-resize-powerflex-thin-datavol

Conversation

@mlsorensen

Copy link
Copy Markdown
Contributor

Description

This PR:

  1. Sets disk format correctly according to thin/thick provisioned PowerFlex volumes when encryption is in play. It delegates the volume format to the implementation (ScaleIOStorageAdaptor) and ensures it is passed back so it is stored properly in the VolumeVO.

This allows us to trigger the code that resizes the qcow2 container if we are thin provisioned - this wasn't working for data volumes when VM was stopped because they were hard coded to RAW format.

  1. Defensive coding in case volume has no VM instance name (detached)

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Tested locally against powerflex, both detached and attached volume.

@codecov

codecov Bot commented Jul 6, 2023

Copy link
Copy Markdown

Codecov Report

Merging #7729 (af36827) into main (2132f46) will increase coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff            @@
##               main    #7729   +/-   ##
=========================================
  Coverage     13.39%   13.39%           
  Complexity     9344     9344           
=========================================
  Files          2743     2743           
  Lines        258571   258571           
  Branches      40279    40279           
=========================================
+ Hits          34630    34632    +2     
- Misses       219569   219570    +1     
+ Partials       4372     4369    -3     
Impacted Files Coverage Δ
...ud/hypervisor/kvm/storage/KVMStorageProcessor.java 5.01% <0.00%> (-0.01%) ⬇️
...atastore/driver/ScaleIOPrimaryDataStoreDriver.java 17.33% <0.00%> (+0.04%) ⬆️

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@harikrishna-patnala harikrishna-patnala left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM. It's better to test the volume operations since we are dealing with volume format here.

@harikrishna-patnala

Copy link
Copy Markdown
Member

@mlsorensen can we target this to 4.18.1 please, this needs to change the base branch.

@mlsorensen

mlsorensen commented Jul 7, 2023 •

Copy link
Copy Markdown
Contributor Author

Closing in favor of #7735 - against 4.18 branch. I wasn't able to change the base branch away from main via edit.

@mlsorensen mlsorensen closed this Jul 7, 2023
@mlsorensen
mlsorensen deleted the main-resize-powerflex-thin-datavol branch July 7, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants