test: fix ci failures on main branch

[shwstppr]

Description

• Fixes k8s test failure on the simulator
• Fixes VPC testcase failures for test_set_sourcenat.py

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

[DaanHoogland]

@blueorangutan package

[blueorangutan]

@DaanHoogland a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[shwstppr]

@DaanHoogland this is still wip. Tests are still failing on GH CI,

+---------------------------------------+---------+-------+--------------------+
|                 Test                  | Result  | Time  |     Test file      |
+=======================================+=========+=======+====================+
| test_03_create_vpc_with_specified_sou | Failure | 7.666 | test_set_sourcenat |
| rce_nat_ip_address                    |         |       |                    |
+---------------------------------------+---------+-------+--------------------+
| test_04_change_source_nat_ip_address_ | Failure | 8.824 | test_set_sourcenat |
| for_vpc                               |         |       |                    |
+---------------------------------------+---------+-------+--------------------+

[codecov]

Codecov Report

Merging #7733 (477d938) into main (a706bf2) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #7733      +/-   ##
============================================
- Coverage     13.39%   13.39%   -0.01%     
+ Complexity     9346     9344       -2     
============================================
  Files          2743     2743              
  Lines        258571   258571              
  Branches      40279    40279              
============================================
- Hits          34639    34630       -9     
- Misses       219558   219569      +11     
+ Partials       4374     4372       -2     

see 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[harikrishna-patnala]

Code LGTM. Let's run the tests.

@blueorangutan package

[yadvr]

@blueorangutan package

[blueorangutan]

@rohityadavcloud a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 6438

[shwstppr]

@blueorangutan test

[blueorangutan]

@shwstppr a [SF] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-7030)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 49424 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7733-t7030-kvm-centos7.zip
Smoke tests completed. 111 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_migrate_VM_and_root_volume	Error	83.83	test_vm_life_cycle.py
test_02_migrate_VM_with_two_data_disks	Error	59.57	test_vm_life_cycle.py
test_05_vmschedule_test_e2e	Failure	266.02	test_vm_schedule.py

[DaanHoogland]

good spot

[yadvr]

@blueorangutan package

[blueorangutan]

@rohityadavcloud a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 6456

[DaanHoogland]

@blueorangutan test

[blueorangutan]

@DaanHoogland a [SF] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-7043)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 754 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7733-t7043-kvm-centos7.zip
Smoke tests completed. 0 look OK, 0 have errors, 113 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
all_test_safe_shutdown	Skipped	---	test_safe_shutdown.py
all_test_scale_vm	Skipped	---	test_scale_vm.py
all_test_2fa	Skipped	---	test_2fa.py
all_test_regions	Skipped	---	test_regions.py
all_test_accounts	Skipped	---	test_accounts.py
all_test_nonstrict_affinity_group	Skipped	---	test_nonstrict_affinity_group.py
all_test_affinity_groups	Skipped	---	test_affinity_groups.py
all_test_internal_lb	Skipped	---	test_internal_lb.py
all_test_usage	Skipped	---	test_usage.py
all_test_affinity_groups_projects	Skipped	---	test_affinity_groups_projects.py
all_test_register_userdata	Skipped	---	test_register_userdata.py
all_test_annotations	Skipped	---	test_annotations.py
all_test_reset_vm_on_reboot	Skipped	---	test_reset_vm_on_reboot.py
all_test_async_job	Skipped	---	test_async_job.py
all_test_ipv6_infra	Skipped	---	test_ipv6_infra.py
all_test_attach_multiple_volumes	Skipped	---	test_attach_multiple_volumes.py
all_test_kubernetes_clusters	Skipped	---	test_kubernetes_clusters.py
all_test_backup_recovery_dummy	Skipped	---	test_backup_recovery_dummy.py
all_test_outofbandmanagement	Skipped	---	test_outofbandmanagement.py
all_test_certauthority_root	Skipped	---	test_certauthority_root.py
all_test_over_provisioning	Skipped	---	test_over_provisioning.py
all_test_console_endpoint	Skipped	---	test_console_endpoint.py
all_test_set_sourcenat	Skipped	---	test_set_sourcenat.py
all_test_create_list_domain_account_project	Skipped	---	test_create_list_domain_account_project.py
all_test_password_server	Skipped	---	test_password_server.py
all_test_create_network	Skipped	---	test_create_network.py
all_test_iso	Skipped	---	test_iso.py
all_test_snapshots	Skipped	---	test_snapshots.py
all_test_deploy_vgpu_enabled_vm	Skipped	---	test_deploy_vgpu_enabled_vm.py
all_test_migration	Skipped	---	test_migration.py
all_test_deploy_virtio_scsi_vm	Skipped	---	test_deploy_virtio_scsi_vm.py
all_test_multipleips_per_nic	Skipped	---	test_multipleips_per_nic.py
all_test_deploy_vm_extra_config_data	Skipped	---	test_deploy_vm_extra_config_data.py
all_test_persistent_network	Skipped	---	test_persistent_network.py
all_test_deploy_vm_iso	Skipped	---	test_deploy_vm_iso.py
all_test_portable_publicip	Skipped	---	test_portable_publicip.py
all_test_deploy_vm_iso_uefi	Skipped	---	test_deploy_vm_iso_uefi.py
all_test_nested_virtualization	Skipped	---	test_nested_virtualization.py
all_test_deploy_vm_root_resize	Skipped	---	test_deploy_vm_root_resize.py
all_test_network	Skipped	---	test_network.py
all_test_deploy_vm_with_userdata	Skipped	---	test_deploy_vm_with_userdata.py
all_test_network_acl	Skipped	---	test_network_acl.py
all_test_deploy_vms_in_parallel	Skipped	---	test_deploy_vms_in_parallel.py
all_test_ssvm	Skipped	---	test_ssvm.py
all_test_deploy_vms_with_varied_deploymentplanners	Skipped	---	test_deploy_vms_with_varied_deploymentplanners.py
all_test_resource_accounting	Skipped	---	test_resource_accounting.py
all_test_diagnostics	Skipped	---	test_diagnostics.py
all_test_portforwardingrules	Skipped	---	test_portforwardingrules.py
all_test_direct_download	Skipped	---	test_direct_download.py
all_test_primary_storage	Skipped	---	test_primary_storage.py
all_test_disk_offerings	Skipped	---	test_disk_offerings.py
all_test_network_ipv6	Skipped	---	test_network_ipv6.py
all_test_disk_provisioning_types	Skipped	---	test_disk_provisioning_types.py
all_test_network_permissions	Skipped	---	test_network_permissions.py
all_test_domain_disk_offerings	Skipped	---	test_domain_disk_offerings.py
all_test_nic	Skipped	---	test_nic.py
all_test_staticroles	Skipped	---	test_staticroles.py
all_test_domain_network_offerings	Skipped	---	test_domain_network_offerings.py
all_test_nic_adapter_type	Skipped	---	test_nic_adapter_type.py
all_test_domain_service_offerings	Skipped	---	test_domain_service_offerings.py
all_test_private_roles	Skipped	---	test_private_roles.py
all_test_domain_vpc_offerings	Skipped	---	test_domain_vpc_offerings.py
all_test_resource_detail	Skipped	---	test_resource_detail.py
all_test_dynamicroles	Skipped	---	test_dynamicroles.py
all_test_hostha_simulator	Skipped	---	test_hostha_simulator.py
all_test_enable_account_settings_for_domain	Skipped	---	test_enable_account_settings_for_domain.py
all_test_human_readable_logs	Skipped	---	test_human_readable_logs.py
all_test_enable_role_based_users_in_projects	Skipped	---	test_enable_role_based_users_in_projects.py
all_test_privategw_acl	Skipped	---	test_privategw_acl.py
all_test_events_resource	Skipped	---	test_events_resource.py
all_test_non_contigiousvlan	Skipped	---	test_non_contigiousvlan.py
all_test_gateway_on_shared_networks	Skipped	---	test_gateway_on_shared_networks.py
all_test_privategw_acl_ovs_gre	Skipped	---	test_privategw_acl_ovs_gre.py
all_test_global_settings	Skipped	---	test_global_settings.py
all_test_router_dhcphosts	Skipped	---	test_router_dhcphosts.py
all_test_guest_os	Skipped	---	test_guest_os.py
all_test_projects	Skipped	---	test_projects.py
all_test_guest_vlan_range	Skipped	---	test_guest_vlan_range.py
all_test_public_ip_range	Skipped	---	test_public_ip_range.py
all_test_host_control_state	Skipped	---	test_host_control_state.py
all_test_kubernetes_supported_versions	Skipped	---	test_kubernetes_supported_versions.py
all_test_pvlan	Skipped	---	test_pvlan.py
all_test_list_ids_parameter	Skipped	---	test_list_ids_parameter.py
all_test_router_dns	Skipped	---	test_router_dns.py
all_test_loadbalance	Skipped	---	test_loadbalance.py
all_test_router_dnsservice	Skipped	---	test_router_dnsservice.py
all_test_login	Skipped	---	test_login.py
all_test_routers	Skipped	---	test_routers.py
all_test_metrics_api	Skipped	---	test_metrics_api.py
all_test_routers_network_ops	Skipped	---	test_routers_network_ops.py
all_test_outofbandmanagement_nestedplugin	Skipped	---	test_outofbandmanagement_nestedplugin.py
all_test_reset_configuration_settings	Skipped	---	test_reset_configuration_settings.py
all_test_routers_iptables_default_policy	Skipped	---	test_routers_iptables_default_policy.py
all_test_secondary_storage	Skipped	---	test_secondary_storage.py
all_test_service_offerings	Skipped	---	test_service_offerings.py
all_test_storage_policy	Skipped	---	test_storage_policy.py
all_test_templates	Skipped	---	test_templates.py
all_test_update_security_group	Skipped	---	test_update_security_group.py
all_test_usage_events	Skipped	---	test_usage_events.py
all_test_vm_autoscaling	Skipped	---	test_vm_autoscaling.py
all_test_vm_deployment_planner	Skipped	---	test_vm_deployment_planner.py
all_test_vm_life_cycle	Skipped	---	test_vm_life_cycle.py
all_test_vm_lifecycle_unmanage_import	Skipped	---	test_vm_lifecycle_unmanage_import.py
all_test_vm_schedule	Skipped	---	test_vm_schedule.py
all_test_vm_snapshot_kvm	Skipped	---	test_vm_snapshot_kvm.py
all_test_vm_snapshots	Skipped	---	test_vm_snapshots.py
all_test_volumes	Skipped	---	test_volumes.py
all_test_vpc_ipv6	Skipped	---	test_vpc_ipv6.py
all_test_vpc_redundant	Skipped	---	test_vpc_redundant.py
all_test_vpc_router_nics	Skipped	---	test_vpc_router_nics.py
all_test_vpc_vpn	Skipped	---	test_vpc_vpn.py
all_test_host_maintenance	Skipped	---	test_host_maintenance.py
all_test_hostha_kvm	Skipped	---	test_hostha_kvm.py

[DaanHoogland]

@shwstppr changes look good, but I am investigating why the tests were skipped. I think we can merge though.

[blueorangutan]

[SF] Trillian test result (tid-7048)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 45614 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7733-t7048-kvm-centos7.zip
Smoke tests completed. 112 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_migrate_VM_and_root_volume	Error	80.67	test_vm_life_cycle.py
test_02_migrate_VM_with_two_data_disks	Error	57.44	test_vm_life_cycle.py