Skip to content

eof lint error on StorpoolStatsCollector - #7754

Merged
DaanHoogland merged 1 commit into
apache:4.18from
shapeblue:eofOnStorePoolStatsCollector
Jul 19, 2023
Merged

eof lint error on StorpoolStatsCollector#7754
DaanHoogland merged 1 commit into
apache:4.18from
shapeblue:eofOnStorePoolStatsCollector

Conversation

@DaanHoogland

@DaanHoogland DaanHoogland commented Jul 19, 2023

Copy link
Copy Markdown
Contributor

Description

This PR...

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

@DaanHoogland
DaanHoogland requested a review from slavkap July 19, 2023 09:31
@DaanHoogland

DaanHoogland commented Jul 19, 2023

Copy link
Copy Markdown
Contributor Author

@slavkap , please have a look at this

@DaanHoogland

DaanHoogland commented Jul 19, 2023

Copy link
Copy Markdown
Contributor Author

/me letting the linnt say it is ok for merge

@DaanHoogland
DaanHoogland merged commit 9c5e489 into apache:4.18 Jul 19, 2023
DaanHoogland added a commit that referenced this pull request Jul 20, 2023
@DaanHoogland
Merge release branch 4.18 to main
afec876 
* 4.18:
  SSVM: 'allow from' private IP in other SSVMs if the public IP is in allowed internal sites cidrs (#7288)
  eof added to StorPoolStatsCollector (#7754)
@DaanHoogland DaanHoogland added this to the 4.19.0.0 milestone Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vishesh92 vishesh92 vishesh92 approved these changes
@slavkap slavkap slavkap approved these changes

Assignees

No one assigned

Labels

component:primary-storage component:storage

Projects

None yet

Milestone

4.19.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@DaanHoogland @vishesh92 @slavkap