[ci] Add versioned Node.js Docker canary - #413
Open
hello-stephen wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Adds an opt-in
nodejs_versioninput to the existing Docker image workflow. When set, the workflow:apache/doris:build-env-ldb-toolchain-node24.19.0;node --versionandnpm --versionfrom the pushed image;latesttags and automation release state untouched.Scheduled and ordinary manual runs retain their current behavior and continue to inherit
NODEJS_VERSIONfrom the upstream Apache Doris Dockerfile.Why
The Doris Compile pipeline currently installs Node with nvm on every build. Its new Gitee bootstrap endpoint has become a shared failure point (
curl (7) Connection timed out). A versioned canary lets us validate Node 24.19.0 in the build image before changing the upstream Dockerfile default or the production Compile pipeline.Validation
git diff --checkactionlintreports only the existing ShellCheck findings from unchanged scriptsARG NODEJS_VERSIONbecomes24.19.0After merge, dispatch
Buildwithnodejs_version=24.19.0. The exact normal image tag will beapache/doris:build-env-ldb-toolchain-node24.19.0.