FINERACT-2752: Charge - Income from charge list is not the same on add and edit mode - #6253
Open
rymghosn wants to merge 1 commit into
Open
Conversation
…nges are visible on reread
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When creating a charge with chargeAppliesTo = Client and selecting an item from the "Income from Charge" (GL income account) list, editing that
charge afterwards showed the previously selected income account as missing, and reopening the dropdown showed fewer available options than
before.
Root cause: ChargeWritePlatformServiceJpaRepositoryImpl#updateCharge persisted the updated charge with a plain chargeRepository.save(). This
defers the actual flush to Hibernate's own timing, so when the same request cycle immediately re-read the charge to build the response (or to
populate the edit-mode dropdown), it could still see the pre-update state — making the income account selection look reverted or absent.
Fix:
already accepts (ChargesApiConstants.glAccountIdParamName).
PR:(https://issues.apache.org/jira/browse/FINERACT-2752)