FINERACT-2749: ft v2 paginated endpoints to resolve ambiguous OpenAPI response typing - #6262
Open
elnafateh wants to merge 1 commit into
Open
FINERACT-2749: ft v2 paginated endpoints to resolve ambiguous OpenAPI response typing#6262elnafateh wants to merge 1 commit into
elnafateh wants to merge 1 commit into
Conversation
…I response typing - Introduce v2 endpoints for Audits, Groups, Centers, FixedDeposit, and RecurringDeposit accounts. - Consistently return the paginated wrapper (totalFilteredRecords, pageItems) to fix OpenAPI schema generation. - Retain v1 behavior for backward compatibility.
Contributor
Author
|
@adamsaghy Pls review this PR sir |
adamsaghy
reviewed
Aug 14, 2026
| return auditReadPlatformService.retrievePaginatedAuditEntries(extraCriteria, includeJson, parameters); | ||
| } | ||
|
|
||
| private SQLBuilder getExtraCriteria(AuditRequest auditRequest) { |
Contributor
There was a problem hiding this comment.
Instead of duplicating, would you mind to move this logic into the service layer? That way both v1 and v2 endpoints can use the same.
Contributor
Author
There was a problem hiding this comment.
yes that's more optimal
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Your assigned reviewer(s) will follow our guidelines for code reviews.