Skip to content

fix(scan): reject missing column stats fields #786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wgtmac wants to merge 1 commit into
base: main
Choose a base branch
from
+12 −3
Open

fix(scan): reject missing column stats fields #786

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/iceberg/table_scan.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -400,9 +400,8 @@ Status TableScanBuilder<ScanType>::ResolveColumnStatsSelection() {
const auto& schema = schema_ref.get();
for (const auto& column_name : *requested_column_stats_) {
ICEBERG_ASSIGN_OR_RAISE(auto field, schema->FindFieldByName(column_name));
if (field.has_value()) {
context_.columns_to_keep_stats.insert(field.value().get().field_id());
}
ICEBERG_CHECK(field.has_value(), "Cannot find stats column: {}", column_name);
context_.columns_to_keep_stats.insert(field.value().get().field_id());
}

return {};
Expand Down
10 changes: 10 additions & 0 deletions src/iceberg/test/table_scan_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,6 +285,16 @@ TEST_P(TableScanTest, IncludeColumnStatsUsesFinalSnapshotSchema) {
}
}

TEST_P(TableScanTest, IncludeColumnStatsRejectsMissingColumn) {
ICEBERG_UNWRAP_OR_FAIL(auto builder,
DataTableScanBuilder::Make(table_metadata_, file_io_));
builder->IncludeColumnStats({"missing"});

EXPECT_THAT(builder->Build(),
::testing::AllOf(IsError(ErrorKind::kValidationFailed),
HasErrorMessage("Cannot find stats column: missing")));
}

TEST_P(TableScanTest, TableScanBuilderValidationErrors) {
// Test negative min rows
ICEBERG_UNWRAP_OR_FAIL(auto builder,
Expand Down
Loading