Improve metadata OOM diagnostics#18039
Open
Caideyipi wants to merge 2 commits into
Open
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #18039 +/- ##
============================================
+ Coverage 41.42% 41.70% +0.27%
Complexity 318 318
============================================
Files 5282 5296 +14
Lines 369246 372014 +2768
Branches 47786 48128 +342
============================================
+ Hits 152978 155165 +2187
- Misses 216268 216849 +581 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
jt2594838
reviewed
Jul 3, 2026
Comment on lines
+668
to
+679
| Locale.ROOT, | ||
| "Not enough memory while analyzing metadata for query result columns. " | ||
| + "The result set has too many columns. " | ||
| + "Before the failure, IoTDB had matched %,d source columns for result-column " | ||
| + "expansion, expanded %,d source columns, and generated %,d result-set columns. " | ||
| + "%s" | ||
| + "Current series pagination is %s. " | ||
| + "Use SLIMIT/SOFFSET to reduce returned series%s, narrow the path pattern, " | ||
| + "or increase query memory%s. " | ||
| + "Memory details: source-column memory for result expansion %s, " | ||
| + "generated-result-column memory %s, requested this time %s, current free memory %s. " | ||
| + "Original error: %s", |
Collaborator
Author
There was a problem hiding this comment.
Applied in 9fa3066: moved the metadata OOM diagnostic text into DataNodeQueryMessages with both English and Chinese i18n constants.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR improves metadata/query-analysis OOM diagnostics when result-set column expansion or schema fetch runs out of memory.
Changes:
MPPQueryContext.MemoryNotEnoughExceptionduring metadata analysis with column counts, SLIMIT/SOFFSET, ALIGN BY DEVICE guidance, memory shortage, and estimated exceeded columns.MPPQueryContextTestcoverage for enriched result-column and schema-fetch OOM messages, plus the no-context fallback path.Verification
mvn spotless:apply -pl iotdb-core/datanodegit diff --checkmvn "-Ddevelocity.off=true" test -pl iotdb-core/datanode -Dtest=MPPQueryContextTestcurrently fails before running tests during datanode main-source compilation because of pre-existing/unrelated missing symbols inAstBuilder,DataNodeMemoryConfig,TableConfigTaskVisitor,DatasetHeaderFactory,ShowCreate*Task, andDataRegionConsensusImpl.