Skip to content

Support attribute filters in table deletion#18079

Open
jt2594838 wants to merge 9 commits into
masterfrom
delete_with_attribute
Open

Support attribute filters in table deletion#18079
jt2594838 wants to merge 9 commits into
masterfrom
delete_with_attribute

Fix table deletion predicate review issues

cf04c05
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis succeeded Jul 1, 2026 in 3m 17s

Quality Gate passed

Issues
16 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
3.3% Duplication on New Code

See analysis details on SonarQube Cloud

Annotations

Check warning on line 19 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/modification/TagPredicate.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

'package' should be separated from previous line. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ8cUcli7UYFBmGm6wRT&open=AZ8cUcli7UYFBmGm6wRT&pullRequest=18079

Check warning on line 2771 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/relational/analyzer/StatementAnalyzer.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

A "Brain Method" was detected. Refactor it to reduce at least one of the following metrics: LOC from 131 to 64, Complexity from 24 to 14, Nesting Level from 6 to 2, Number of Variables from 28 to 6. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ8cUcrv7UYFBmGm6wRY&open=AZ8cUcrv7UYFBmGm6wRY&pullRequest=18079

Check warning on line 742 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/analyze/AnalyzeUtils.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Merge the previous cases into this one using comma-separated label. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ8c5HwqtSRAbF5ZOjvj&open=AZ8c5HwqtSRAbF5ZOjvj&pullRequest=18079

Check failure on line 467 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/analyze/AnalyzeUtils.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 61 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ8cUcsk7UYFBmGm6wRd&open=AZ8cUcsk7UYFBmGm6wRd&pullRequest=18079

Check warning on line 2633 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/DataRegion.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

A "Brain Method" was detected. Refactor it to reduce at least one of the following metrics: LOC from 81 to 64, Complexity from 19 to 14, Nesting Level from 5 to 2, Number of Variables from 17 to 6. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ8cUcpH7UYFBmGm6wRX&open=AZ8cUcpH7UYFBmGm6wRX&pullRequest=18079

Check warning on line 527 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/analyze/AnalyzeUtils.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this instanceof check and cast with 'instanceof IsNotNullPredicate isnotnullpredicate' 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ8cUcsk7UYFBmGm6wRe&open=AZ8cUcsk7UYFBmGm6wRe&pullRequest=18079

Check warning on line 3518 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/relational/analyzer/StatementAnalyzer.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

A "Brain Method" was detected. Refactor it to reduce at least one of the following metrics: LOC from 121 to 64, Complexity from 18 to 14, Nesting Level from 3 to 2, Number of Variables from 35 to 6. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ8cUcrv7UYFBmGm6wRZ&open=AZ8cUcrv7UYFBmGm6wRZ&pullRequest=18079

Check warning on line 5220 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/relational/analyzer/StatementAnalyzer.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

A "Brain Method" was detected. Refactor it to reduce at least one of the following metrics: LOC from 81 to 64, Complexity from 15 to 14, Nesting Level from 3 to 2, Number of Variables from 25 to 6. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ8cUcrv7UYFBmGm6wRb&open=AZ8cUcrv7UYFBmGm6wRb&pullRequest=18079

Check warning on line 3877 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/relational/analyzer/StatementAnalyzer.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

A "Brain Method" was detected. Refactor it to reduce at least one of the following metrics: LOC from 81 to 64, Complexity from 15 to 14, Nesting Level from 3 to 2, Number of Variables from 18 to 6. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ8cUcrv7UYFBmGm6wRc&open=AZ8cUcrv7UYFBmGm6wRc&pullRequest=18079

Check warning on line 467 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/analyze/AnalyzeUtils.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

A "Brain Method" was detected. Refactor it to reduce at least one of the following metrics: LOC from 114 to 64, Complexity from 26 to 14, Nesting Level from 4 to 2, Number of Variables from 15 to 6. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ8cUcsk7UYFBmGm6wRg&open=AZ8cUcsk7UYFBmGm6wRg&pullRequest=18079

Check warning on line 146 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/modification/TagPredicate.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Abbreviation in name 'NOP' must contain no more than '2' consecutive capital letters. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ8cUcli7UYFBmGm6wRU&open=AZ8cUcli7UYFBmGm6wRU&pullRequest=18079

Check warning on line 3484 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/DataRegion.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

A "Brain Method" was detected. Refactor it to reduce at least one of the following metrics: LOC from 149 to 64, Complexity from 29 to 14, Nesting Level from 5 to 2, Number of Variables from 26 to 6. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ8cUcpH7UYFBmGm6wRV&open=AZ8cUcpH7UYFBmGm6wRV&pullRequest=18079

Check warning on line 3227 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/relational/analyzer/StatementAnalyzer.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

A "Brain Method" was detected. Refactor it to reduce at least one of the following metrics: LOC from 82 to 64, Complexity from 16 to 14, Nesting Level from 3 to 2, Number of Variables from 25 to 6. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ8cUcrv7UYFBmGm6wRa&open=AZ8cUcrv7UYFBmGm6wRa&pullRequest=18079

Check warning on line 19 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/exception/DirectBufferMemoryAllocationException.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

'package' should be separated from previous line. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ8cUctw7UYFBmGm6wRh&open=AZ8cUctw7UYFBmGm6wRh&pullRequest=18079

Check warning on line 3071 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/DataRegion.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

A "Brain Method" was detected. Refactor it to reduce at least one of the following metrics: LOC from 97 to 64, Complexity from 17 to 14, Nesting Level from 7 to 2, Number of Variables from 24 to 6. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ8cUcpH7UYFBmGm6wRW&open=AZ8cUcpH7UYFBmGm6wRW&pullRequest=18079

Check warning on line 660 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/analyze/AnalyzeUtils.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this instanceof check and cast with 'instanceof And and' 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ8cUcsk7UYFBmGm6wRf&open=AZ8cUcsk7UYFBmGm6wRf&pullRequest=18079
View more details on SonarQubeCloud