Fix C++ client DATE 1000-01-01 query crash#18096
Open
hongzhi-gao wants to merge 1 commit into
Open
Conversation
Stop treating EMPTY_DATE_INT as a null sentinel when decoding query results, since it encodes the valid date 1000-01-01 and caused C API reads to throw in parseDateExpressionToInt.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix C++ client crash when querying DATE
1000-01-01:EMPTY_DATE_INT(10000101) was wrongly treated as NULL during decode, but it is also the valid encoding for1000-01-01, causing C APIparseDateExpressionToIntto throw.This PR has:
Key changed/added classes (or packages if there are too many classes) in this PR
iotdb-client/client-cpp/src/session/Date.cppiotdb-client/client-cpp/src/include/Common.hiotdb-client/client-cpp/src/session/SessionC.cppiotdb-client/client-cpp/test/cpp/sessionIT.cppiotdb-client/client-cpp/test/cpp/sessionCIT.cppTest plan
session_tests.exe "[dateMinYear]"passedsession_c_tests.exe "[c_dateMinYear]"passedsession_testsandsession_c_testspassed against local IoTDB