Repository navigation
fix(release): recover macOS ticket delivery and validation - #6280
Conversation
Generated-by: OpenAI Codex
Generated-by: OpenAI Codex
Generated-by: OpenAI Codex
|
Reviewed at I found no blocking issues in the changed paths. The retry remains limited to exit code Independent verification:
The hosted TCP workaround matches the runner maintainers' recommendation. I inspected the existing hosted probe logs but did not rerun that job. The full workspace tests/typecheck and a newly signed build of this PR were outside this verification. Please retain the tracked post-merge qualification: run one Nightly containing this fix through all five Desktop targets and publication. The existing Nightly 101 success does not qualify this patch. Source review and local test execution were assisted by OpenAI Codex. 中文全文本次审核对应提交 在本次修改涉及的路径中,未发现阻止合并的问题。重试仍限定为退出码 独立验证结果:
CI 中的 TCP 绕过措施与 Runner 维护者的建议一致。我检查了已有的 Runner 探测日志,但没有重新运行该作业。本次验证未覆盖整个仓库的测试和类型检查,也没有为该 PR 重新生成签名安装包。 请保留已记录的合并后验收项:运行一次包含此修复的 Nightly,完成全部五个 Desktop 目标及发布流程。已有 Nightly 101 的成功不能作为本补丁的验收结果。 源码审查和本地测试执行由 OpenAI Codex 辅助完成。 |
sunrioa
left a comment
There was a problem hiding this comment.
Approved for 527103d5b2e90998f64a3ab06560cfaaf049d82b. Detailed verification and the remaining post-merge Nightly qualification are recorded in the review notes.
Submitted through OpenAI Codex at the explicit direction of human reviewer @sunrioa.
Summary
Nightly 101 completed all five Desktop targets and the publisher without this fix, and 0.2.2-dev.101.20261026 is published. This PR is release reliability hardening: it addresses the diagnostic and recovery gaps observed in earlier failures, plus the runner maintainers' workaround for intermittent ticket connection loss. It is no longer blocking publication. I am keeping it open for review; no additional exploratory runs are planned.
Nightly 98 failed at
stapler validateon the app copied from its notarized ARM64 DMG (failure). The check bypassed the existing recovery gate, andrunCommandomitted stdout and exit metadata. Reuse the gate in validation-only mode and retain command status and both output streams. App validation remains read-only; only exit 68 withNSURLErrorDomain Code=-1005gets three attempts and 10/20-second delays.Nightly 99 exhausted those existing attempts earlier, while stapling its accepted ARM64 DMG. GitHub runner maintainers reproduced the same CloudKit connection loss over HTTP/3 and verified TCP fallback. Apply their temporary UDP 443 block before notarization in the hosted macOS Desktop Nightly, Desktop release and CLI release jobs. This covers app, DMG and validation lookups without adding a new recovery path or weakening ticket checks. Remove the workaround when the runner issue is fixed. Local packaging is unchanged; the disposable CI jobs use HTTPS over TCP.
Verification
git diff --checkpassed.527103d5b.Release qualification
The first post-merge attempt, npm run 40625327778, used source
ed3f91707cfe96c240b92e4911255ef47a64b403and version0.2.2-dev.103.20261028. All installed CLI validation jobs passed. Publication stopped at the shipped-dependency audit becauseqs@6.16.0matches GHSA-6pq8-jhm2-2vcw (moderate; fixed in 6.16.1). The downstream Desktop run 40626707958 was skipped, so the macOS changes remain unqualified by a post-merge release. The existing dependency update is tracked in #6408.Nightly 101 establishes that publication recovered without this PR. It does not qualify the changes below; after merge, I will verify one Nightly containing the fix through the existing release process.
AI use
Tool(s) and scope: OpenAI Codex investigated the release failures, implemented the fixes and regression tests, and ran local checks and the hosted network probe.
Checklist
Does this PR entail a change in behavior?