Repository navigation
ci: check rust-preview pull requests and the workbench UI sources - #6488
Conversation
Generated-by: Claude Code
Astro-Han
left a comment
There was a problem hiding this comment.
Automated review notice: This comment was posted by an automated review agent. It is not an independent human review and does not replace one.
I reviewed all five changed files at 486711a8fa9309c9c4ec4fd3733235d5c6645ec5, plus the surrounding cache restore/save configuration, the just check dependency chain and the existing ui_types generator.
I found no confirmed P0–P2 in this scope. The CI workflow now selects main and rust-preview pull requests and pushes; Computer Use adds rust-preview pull requests while retaining its path filter. The cache key remains commit-specific with restore prefixes. I parsed both YAML files and evaluated the actual four changed cache/GC expressions across six controlled contexts: main/rust-preview pushes, another-branch push, a pull request, manual dispatch and an existing exact cache hit. Export/save remained limited to the intended pushes and were disabled on a hit; pull requests did not acquire cache-write behavior. Workflow permissions remain contents: read.
The added typecheck line uses a fresh external output directory and runs the current Rust generator before the repository TypeScript compiler, with && preserving failure propagation. Its shell syntax passed. I read the generator's actual App, conversation/composer and other UI entry points and its current NSH/Host declarations; I did not run the generator or TypeScript project locally. The two UI corrections normalize an absent Bot Session to null and avoid calling latestToolActivity with a null Turn. Both changed TSX files passed a syntax-only Biome 2.5.9 parse, which is not a substitute for the new typecheck.
The real merge-tree against rust-preview 2d679ea33f6d34de059625691d437cb1d17569dd and git diff --check passed. This PR has triggered CI run 41086005520 and Computer Use run 41086005838, so the new PR routing is observable; their overall results are not yet complete. That does not establish that the new typecheck or native tests pass.
I did not execute just check, Rust/NSH builds, Actions cache transfer, the full TypeScript check or native UI. The additional full CI run on every rust-preview push is an explicit operational cost of this change. There is no wire-protocol or database migration change.
Automated review notice: This comment was posted by an automated review agent operated by Astro-Han. It is not an independent human review and does not replace one.
CI follow-up for unchanged head I checked causality against the actual parent
|
Generated-by: Claude Code
Generated-by: Claude Code
|
The notices failure was stale on rust-preview itself, as the review found. faab12f merges current rust-preview (a578d26) and regenerates |
Remove redundant UI guards now that the shared contracts accept nullable values. The complete just typecheck chain passes against current rust-preview. Generated-by: OpenAI Codex
Run CI on pull requests and pushes to
rust-preview, keep its compiled Rust cache warm for subsequent PRs, and include the actual workbench UI sources injust typecheckusing fresh NSH and Host declarations.rust-previewPRs.ui_typesgenerator and repository TypeScript compiler.Validation: the full
just typecheckchain, notices regression test, workflow YAML/routing and permissions checks, and whitespace checks pass locally. Hosted checks also exercise the new PR triggers.AI use
Claude Code authored the original change; OpenAI Codex synchronized it with the current base, removed redundant guards and validated it.