Repository navigation
test(runtime): align cleanup and crash recovery coverage - #6533
Merged
Merged
Conversation
Generated-by: OpenAI Codex
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CI still asserted the cleanup propagation policy from before #6527: a failed child retired its caller or made the caller's scope fail. Align those regression tests with invocation isolation. The original wrapper must remain usable, the actual failed child must retain its payload and capacity, and original receipts and shutdown failures remain observable. Remove the obsolete native-caller failure polling and redundant internal call/phase assertions.
The crash-recovery test from #6519 could reconnect while SIGKILL was still taking effect. Own the first real Host process and await its SIGKILL exit before recovery through
connect_root. Keep the changed incarnation, ended original turn, preserved history and successful new-message checks. All five modified files are tests.Verification
AI use
Tool(s) and scope: OpenAI Codex diagnosed the CI failures, updated the existing tests, and validated and reviewed the changes.
Checklist
Does this PR entail a change in behavior?