Skip to content

test(client): allow expected query relay disconnects on cancellation - #6534

Merged
M4n5ter merged 1 commit into
rust-previewfrom
fix/client-cancellation-relay
Nov 1, 2026
Merged

M4n5ter merged 1 commit into
rust-previewfrom
fix/client-cancellation-relay

Conversation

@M4n5ter

@M4n5ter M4n5ter commented Nov 1, 2026

Copy link
Copy Markdown
Member

Summary

The client cancellation tests deliberately close a query socket with unread data. Their proxy could receive ConnectionReset after every anchor acknowledgement assertion had passed, then fail the test while joining its relay task.

Accept ConnectionReset and BrokenPipe at that query relay boundary. Unexpected I/O errors and worker panics still fail. Both tests continue to require that close waits for the original anchor acknowledgement and that missing acknowledgement returns an error. The change touches one test file.

Verification

  • All 28 client library tests pass with compiler warnings denied, including both withheld-opening/anchor-ack cases.
  • Client Clippy with all targets and warnings denied passes.
  • Rust formatting and diff whitespace checks pass.
  • Read-only advisor review found no blocker.
  • The parent revision's full CI passed; the companion normal run exposed this proxy teardown race.

AI use

  • Generative tooling made a substantive contribution

Tool(s) and scope: OpenAI Codex diagnosed the CI failure, updated the test proxy and ran validation.

Checklist

  • Existing cancellation and anchor-custody tests cover the behavior.
  • Relevant local tests, lint and formatting pass.

Does this PR entail a change in behavior?

  • No

@M4n5ter
M4n5ter merged commit 7b27509 into rust-preview Nov 1, 2026
1 of 2 checks passed
@M4n5ter
M4n5ter deleted the fix/client-cancellation-relay branch November 1, 2026 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant