Remove Netbinox dependency from MavenOSGI and support Export-Package with multi-package entries#9426
Open
matthiasblaesing wants to merge 2 commits into
Open
Remove Netbinox dependency from MavenOSGI and support Export-Package with multi-package entries#9426matthiasblaesing wants to merge 2 commits into
matthiasblaesing wants to merge 2 commits into
Conversation
matthiasblaesing
added
Java
Contributor
Author
|
@YannLeCorse would you mind having a look? This is a followup to #9310, covering another formatting option of "Export-Package" declaration. |
Contributor
Hi, sorry for delay. Will try to have a look on Monday. Cheers. |
Member
|
|
…` with multi-package entries
The OSGI specification allows `Export-Package" to contain multiple
export entries, that in turn can each hold multiple package names.
These two should be considered equal:
Export-Package: com.acme.foo;com.acme.bar;version=1.23
and
Export-Package: com.acme.foo;version=1.23,com.acme.bar;version=1.23
The "NetBeans OSGi Integration" only supported the second version. This
adds the first.
The implementation of the Export-Package parser in "Netbeans OSGi
Integration" can be reused in the "Maven OSGi" so that the Netbinox
dependency can be removed from that module.
matthiasblaesing
force-pushed
the
reduce-equinox
branch
from
86c997d to
93bd5ff
Compare
Contributor
Author
|
Unless there are objections I intent to merge this some time next week. |
mbien
approved these changes
Jun 21, 2026
mbien
left a comment
mbien
left a comment
Member
There was a problem hiding this comment.
changes and cleanup look good to me.
I haven't tested but we can keep an eye on it once its in.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The OSGI specification allows `Export-Package" to contain multiple
export entries, that in turn can each hold multiple package names.
These two should be considered equal:
and
The "NetBeans OSGi Integration" only supported the second version. This
adds the first.
The implementation of the Export-Package parser in "Netbeans OSGi
Integration" can be reused in the "Maven OSGi" so that the Netbinox
dependency can be removed from that module.