MINIFICPP-2870 Lint/Check python code with ruff - #2237
Open
martinzink wants to merge 11 commits into
Open
Conversation
8 tasks
martinzink
changed the title
martinzink
added
low-impact
lordgamez
self-requested a review
August 14, 2026 09:58
lordgamez
approved these changes
Aug 14, 2026
szaszm
reviewed
Aug 17, 2026
Comment on lines
+391
to
+393
| error_message = ( | ||
| f"Command to read file '{path}' failed with exit code {exit_code}" | ||
| ) |
Member
There was a problem hiding this comment.
I find this reformatting weird, why change it from a single line?
Since it's automated reformatting, I don't mind it, just wanted to bring some attention to this.
Comment on lines
+88
to
100
| @step( | ||
| 'a directory at "{directory}" has a file with the content "{content}" in the "{flow_name}" flow' | ||
| ) | ||
| @step( | ||
| "a directory at '{directory}' has a file with the content '{content}' in the '{flow_name}' flow" | ||
| ) | ||
| def create_file_with_content_in_directory_for_flow( | ||
| context: MinifiTestContext, directory: str, content: str, flow_name: str | ||
| ): | ||
| __add_directory_with_file_to_container( | ||
| context, directory, str(uuid.uuid4()), content, flow_name | ||
| ) | ||
|
|
Member
There was a problem hiding this comment.
same, we're expanding 4 lines into 11 slightly shorter lines, I don't think this improves readability, but if the python community consensus suggests this, then I won't complain
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MINIFICPP-2870 Lint/Check python code with ruff
I've deliberetly done the PR in multiple commits, because that would make the review process much easier.
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically main)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.