arch/arm: remove duplicate .globl for up_saveusercontext#19220
Merged
Conversation
The up_saveusercontext symbol was declared with .globl twice in a row. The .globl directive is idempotent, so the duplicate line has no effect on the generated object; drop it to match the single declaration used by the other .S files in this directory. Signed-off-by: Junbo Zheng <zhengjunbo1@xiaomi.com>
The up_saveusercontext symbol was declared with .globl twice in a row. The .globl directive is idempotent, so the duplicate line has no effect on the generated object; drop it to match the single declaration used by the other .S files in this directory. Signed-off-by: Junbo Zheng <zhengjunbo1@xiaomi.com>
The up_saveusercontext symbol was declared with .globl twice in a row. The .globl directive is idempotent, so the duplicate line has no effect on the generated object; drop it to match the single declaration used by the other .S files in this directory. Signed-off-by: Junbo Zheng <zhengjunbo1@xiaomi.com>
The up_saveusercontext symbol was declared with .globl twice in a row. The .globl directive is idempotent, so the duplicate line has no effect on the generated object; drop it to match the single declaration used by the other .S files in this directory. Signed-off-by: Junbo Zheng <zhengjunbo1@xiaomi.com>
The up_saveusercontext symbol was declared with .globl twice in a row. The .globl directive is idempotent, so the duplicate line has no effect on the generated object; drop it to match the single declaration used by the other .S files in this directory. Signed-off-by: Junbo Zheng <zhengjunbo1@xiaomi.com>
The up_saveusercontext symbol was declared with .globl twice in a row. The .globl directive is idempotent, so the duplicate line has no effect on the generated object; drop it to match the single declaration used by the other .S files in this directory. Signed-off-by: Junbo Zheng <zhengjunbo1@xiaomi.com>
The up_saveusercontext symbol was declared with .globl twice in a row. The .globl directive is idempotent, so the duplicate line has no effect on the generated object; drop it to match the single declaration used by the other .S files in this directory. Signed-off-by: Junbo Zheng <zhengjunbo1@xiaomi.com>
github-actions
Bot
added
Arch: arm
|
xiaoxiang781216
approved these changes
Jun 26, 2026
acassis
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Each
arm_saveusercontext.Sunderarch/arm/src/declared theup_saveusercontextsymbol with.globlon two consecutive, identical lines.The
.globldirective is idempotent, so the second declaration is a no-op thathas no effect on the generated object — it is just dead text that diverges from
the single-declaration convention used by every other
.Sfile in thesedirectories.
This PR removes the redundant
.globl up_saveusercontextline from each of theseven affected ARM sub-architectures (one commit per file):
arch/arm/src/arm/arm_saveusercontext.Sarch/arm/src/armv6-m/arm_saveusercontext.Sarch/arm/src/armv7-a/arm_saveusercontext.Sarch/arm/src/armv7-m/arm_saveusercontext.Sarch/arm/src/armv7-r/arm_saveusercontext.Sarch/arm/src/armv8-m/arm_saveusercontext.Sarch/arm/src/armv8-r/arm_saveusercontext.SImpact
.globlis idempotent.This is a pure source-cleanup change with no functional effect.
Testing
This is a no-op source cleanup:
.globlis idempotent, so removing theduplicate declaration cannot change the generated object — the symbol table for
up_saveusercontextis identical before and after.Verified only that the affected sub-architectures still build cleanly
(
tools/configure.sh <board>:nsh+make -j22)