fix(vortex): avoid footer read deadlock#402
Merged
Merged
Conversation
Upgrade Vortex to a version where unknown plugin policy reads no longer lazily write session state while footer layout decoding holds a layout registry borrow. Adapt Arrow conversion to the Vortex session execution API and keep constant_time_eq below 0.5.0 so a fresh resolver remains compatible with Rust 1.91. Signed-off-by: QuakeWang <wangfuzheng0814@foxmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Vortex 0.68 can hang while decoding file footers because
session.layouts().registry()keeps a session borrow alive whilesession.allows_unknown()may lazily insert default session state. That can require a write lock on the same session map and deadlock.Brief change log
allows_unknown()no longer lazily writes session state.constant_time_eqbelow 0.5.0 so fresh dependency resolution remains compatible with Rust 1.91.Tests
RUSTUP_TOOLCHAIN=1.91.0 cargo fmt --all -- --checkgit diff --checkRUSTUP_TOOLCHAIN=1.91.0 cargo clippy --all-targets --workspace --features fulltext,vortex,mosaic -- -D warningsRUSTUP_TOOLCHAIN=1.91.0 cargo build --features fulltext,vortex,mosaicRUSTUP_TOOLCHAIN=1.91.0 cargo test -p paimon --all-targets --features fulltext,vortex,mosaictimeout 120s taskset -c 0 env RUSTUP_TOOLCHAIN=1.91.0 cargo test -p paimon-datafusion --features vortex --test vortex_tables -- --nocaptureAPI and Format
Documentation