[globalindex] Fix NPE in SortedFileMetaSelector when index contains empty string key#8312
Open
weibangpeng wants to merge 1 commit into
Open
Conversation
…mpty string key Add null checks for firstKey/lastKey in compareFirstKey, compareLastKey, and overlaps methods to handle null key boundaries gracefully instead of throwing NullPointerException. Closes apache#7811
weibangpeng
force-pushed
the
fix-7811-npe-sorted-file-meta-selector
branch
from
50d6f01 to
57d1061
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix NullPointerException when using btree global index on STRING columns with empty string keys.
Root cause
When
SortedIndexFileMeta.firstKey()orlastKey()returns null (from null-flagged index file metadata),compareFirstKey/compareLastKey/overlapspasses null todeserialize(), causing NPE.Fix
Add null guards:
compareFirstKey: return -1 for null firstKey (no lower bound)compareLastKey: return 1 for null lastKey (no upper bound)overlaps: skip comparison when key is nullTest
Added
testEmptyStringKeyDoesNotThrowNPEcovering visitEqual, visitLessThan, visitGreaterThan, visitIn, and visitBetween.Closes #7811