PHOENIX-7901: Support JDK 11/17/21 in phoenix-adapters#10
Open
jinggou wants to merge 4 commits into
Open
Conversation
- Fix jacoco wiring with propertyName configuration - Add JDK 21 profile matching upstream Phoenix (split from JDK 17) - Change JDK 17 activation range from [17,) to [17,21) - Add phoenix-surefire.jdk21.flags for SystemExitRule compatibility - Drop CMS flags from JDK 11 tuning (CMS removed in JDK 14) - Add surefire.Xms property for parity with upstream - Remove unused java.version property - Fix jacoco tag style to self-closed format - Move and clarify comment placement All changes align with Apache Phoenix master pom.xml conventions and ensure compatibility with JDK 14-16 (CMS removed in JEP 363). Reference: PHOENIX-7036, commit 48d712ca
virajjasani
reviewed
Jul 1, 2026
|
|
||
| strategy: | ||
| matrix: | ||
| java: [8, 11, 17, 21] |
Contributor
There was a problem hiding this comment.
This can consume too many resources of github workflow. Can we only include Java 8 and 17?
- PRs: Test only JDK 8 for fast feedback (~10-15 min) - Push to main: Test JDK 8 + 17 for baseline and --add-opens verification - Reduces PR CI time by 75% while maintaining coverage on main branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.