PHOENIX-7945 Fix OrphanDeleteMarkerCompactionIT timeout on HBase 2.6 (addendum)#2565
Open
ujjawal4046 wants to merge 1 commit into
Open
PHOENIX-7945 Fix OrphanDeleteMarkerCompactionIT timeout on HBase 2.6 (addendum)#2565ujjawal4046 wants to merge 1 commit into
ujjawal4046 wants to merge 1 commit into
Conversation
…(addendum) HBase 2.6 moved Admin.flush() from ZK-based execProcedure to ProcedureV2 (FlushTableProcedure). The RemoteProcedureDispatcher uses a DelayQueue keyed on EnvironmentEdgeManager.currentTime() with a default 150ms delay. When ManualEnvironmentEdge is injected and only the blocked test thread can advance time, the dispatch item never expires — deterministic deadlock. Set hbase.procedure.remote.dispatcher.delay.msec=0 so the dispatch item expires immediately, consistent with the fix already applied to 10+ other Phoenix test classes after PHOENIX-7353/7354.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hbase.procedure.remote.dispatcher.delay.msec=0toOrphanDeleteMarkerCompactionIT.doSetup()to prevent deterministic deadlock on HBase 2.6 CI profile.Root Cause
HBase 2.6 (HBASE-26867) moved
Admin.flush()from ZK-basedexecProcedureto ProcedureV2 (FlushTableProcedure→FlushRegionProcedure). TheRemoteProcedureDispatcheruses aDelayQueuekeyed onEnvironmentEdgeManager.currentTime()with a default 150ms delay. WhenManualEnvironmentEdgeis injected and only the blocked test thread can advance time, the dispatch item never expires — deterministic deadlock causing 120s timeout.Fix
Set
hbase.procedure.remote.dispatcher.delay.msec=0so the dispatch item expires immediately from theDelayQueue. This is consistent with the fix already applied to 10+ other Phoenix test classes after PHOENIX-7353/7354.Test plan
OrphanDeleteMarkerCompactionITpass on HBase 2.6 profile (59.76s)