Fix the Python 1.3.0 release metadata leaked by the release automation - #897
Merged
Conversation
The 1.3.0 release commit (#896) was generated with un-interpolated GitHub Actions template syntax, which broke the site build and published wrong metadata: - data/docs.yml carried `commitId: ${{ steps.release.outputs.commit-id }}` verbatim. docs.js shells that value into `./doc.sh`, so /bin/sh reported "Bad substitution" and the scheduled Build site workflow has failed on every run since the merge. Both entries now point at 1bd4692, the v1.3.0 tag commit. - The v1.2.0 docs entry had been overwritten rather than a v1.3.0 entry inserted, leaving version `1.3.0` (no v prefix) linked to the v1.2.0 path. Restore v1.2.0 and add a proper v1.3.0 entry. - data/releases.yml replaced the 1.2.0 download links instead of demoting them to archive.apache.org, so 1.2.0 was no longer downloadable. Demote 1.2.0 and keep v1.3.0 on closer.cgi/downloads.apache.org. - The event post rendered as "Release Apache SkyWalking Python " with an empty version everywhere, including a broken PyPI link (apache-skywalking//), and listed no changes. Rewrite it with the 1.3.0 release notes, and rename the directory to the dashed slug convention used by every other release post.
❌ Deploy Preview for skywalking-website-preview failed.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Python 1.3.0 release commit (#896) was generated with un-interpolated GitHub Actions template syntax. The site build has failed on every scheduled run since it merged, and the metadata it published is wrong in several places.
The build failure
data/docs.ymlwas committed with the template literal:docs.jsinterpolates that value into a shell command (execSync("./doc.sh" ... "${commitId}" ...)), so/bin/shreportsBad substitutionand the build exits 1. See the failing run: https://github.com/apache/skywalking-website/actions/runs/31878513365/job/94997629899Both entries now point at
1bd4692f927a4c6156bc25d18d36d9cba76405df, thev1.3.0tag commit. Re-running the exactdoc.shinvocation that CI failed on now succeeds.Other placeholder damage from the same commit
data/docs.yml— thev1.2.0entry was overwritten rather than a new entry inserted, so the version dropdown lost 1.2.0 and showed1.3.0(novprefix) pointing at thev1.2.0doc path. Restoresv1.2.0and adds a properv1.3.0entry sharing theLatestcommitId.data/releases.yml— the 1.2.0 download links were replaced instead of demoted, so 1.2.0 was no longer downloadable at all. Demotes 1.2.0 toarchive.apache.organd keeps v1.3.0 oncloser.cgi/downloads.apache.org. Also fixes the distribution entry's missingvprefix and normalizes the date format.content/events/…— the post rendered asRelease Apache SkyWalking Pythonwith the version missing from the title, description and body, a broken PyPI link (apache-skywalking//), and no changes listed. Rewritten with the actual 1.3.0 release notes. The directory is also renamed to the dashed slug convention (…-python-1-3-0) used by every other release post; the dotted URL was never deployed, since the build has been broken since the release merged.Worth checking whatever generated #896 before the next release — it will reproduce this.