wrap getDate() IllegalStateException in rich parser date getters#76
Open
aizu-m wants to merge 1 commit into
Open
wrap getDate() IllegalStateException in rich parser date getters#76aizu-m wants to merge 1 commit into
aizu-m wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rich parser threw on an xsd:dateTime element instead of reporting a bad value:
getDateValue turns the parsed GDate into a java.util.Date via GDateBuilder.getDate(). getDate() throws IllegalStateException, not IllegalArgumentException, when the value is not a complete date (a time, gYear or gYearMonth reaching the field) or its year is before the Julian epoch. The getter caught only IllegalArgumentException, so the IllegalStateException escaped.
Traced the same shape through getAttributeDateValue by index and by name. getCalendarValue is unaffected since getCalendar() only sets calendar fields, and getGDateValue returns the GDate without the Date conversion.
The other getters and the JavaGDateHolderEx validate path already surface a bad value as InvalidLexicalValueException. Widened the catch on the three getDate() sites to match, and added a test driving the time, gYear and pre-epoch cases plus the attribute overloads.