docs: unify crawl caps and fix the runnable code examples#1002
Merged
Conversation
Lower the page cap from 50 to 10 across all crawling examples so the browser-based ones finish within the runnable-demo timeout. Make Selenium (snippet too large for the Run-on-Apify URL) and Browser Use (needs an LLM API key) non-runnable with explanatory comments, keep both Scrapling examples runnable, and have the Pydantic example fail cleanly via `Actor.fail` instead of re-raising into a raw traceback.
vdusek
added
adhoc
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1002 +/- ##
==========================================
+ Coverage 90.51% 91.61% +1.09%
==========================================
Files 49 49
Lines 3132 3171 +39
==========================================
+ Hits 2835 2905 +70
+ Misses 297 266 -31
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
vdusek
changed the title
szaganek
approved these changes
Jun 19, 2026
Pijukatel
approved these changes
Jun 19, 2026
vdusek
added a commit
that referenced
this pull request
Jun 19, 2026
Backports the documentation fixes from #1002 into the v3 versioned docs (`website/versioned_docs/version-3.4/`). The original PR only updated the next (`docs/`) docs, so the released v3 guides were left out of sync. The changes were applied by extracting #1002's diff and re-pointing it at the versioned tree. Every touched file is now byte-identical to its `docs/` counterpart. What it carries over: - Lower the page cap from 50 to 10 across all crawling examples, so the browser-based ones finish within the 180s runnable-demo timeout. - Selenium: slim the runnable example to a plain crawler, and move the proxy-auth extension into a separate, non-runnable snippet (`code/04_selenium_proxy.py`). - Browser Use: make it non-runnable (needs an LLM API key the shared runner can't provide); same note added to the Scrapy and Scrapling-browser examples. - Pydantic: log a readable validation summary and fail cleanly via `Actor.fail`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the "Run on Apify" examples in the Python SDK guides.
Actor.failinstead of re-raising into a raw traceback.